review requested #1
Conversation
✅ Deploy Preview for cyf-junitalama-tv ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
script.js
Outdated
| @@ -1,12 +1,100 @@ | |||
| //You can edit ALL of the code here | |||
| const allEpisodes = getAllEpisodes(); | |||
| function setup() { | |||
| const allEpisodes = getAllEpisodes(); | |||
There was a problem hiding this comment.
you have declared allEpisodes above, so i think you can skip this line of code as it is repeated
script.js
Outdated
| divEle.append( | ||
| episodeName, | ||
| lineEle, | ||
| image, |
There was a problem hiding this comment.
i learn from you too :) i didn't know you can add them all at one go, cool!!
| let options = document.createElement("option"); | ||
| options.value = el.name; | ||
| options.innerText = `${el.name} - S${el.season.toString().padStart(2, "0")}E${el.number.toString().padStart(2, "0")}`; | ||
|
|
There was a problem hiding this comment.
Great job getting everything working up to level-300!
I think it was optional anyway, but the only thing missing in terms of functionality is being able to easily go back to seeing all episodes after using the dropdown - the only way to get them back right now is to start typing and then delete again.
I think in terms of style/readability, it's good to break up code into some smaller sub-functions - it can make the code much easier to read (because usually a function says what it does), and easier for you to think about too. There is a lot happening in these functions! And the 300 level bit could be put ("encapsulated") in a function.
script.js
Outdated
| const searchInput = searchEle.value.toLowerCase(); | ||
| const filteredEpisodes = allEpisodes.filter(episode => { | ||
| if (episode.name.toLowerCase().includes(searchInput) || episode.summary.toLowerCase().includes(searchInput)){ | ||
| return episode; | ||
| } | ||
| }) | ||
| document.querySelector("#num").innerText = filteredEpisodes.length; | ||
| makePageForEpisodes(filteredEpisodes); | ||
| }) |
There was a problem hiding this comment.
Here the indentation looks a bit flat, like the last 3 lines start at the same line, but they are not at the same scope level.
| "program": "${workspaceFolder}/script.js" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
VS code settings are usually not committed, you could add this file to your gitignore.
|
Great job!💯🏅 |
No description provided.