Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ColPack with SparseMatrixColorings #244

Merged

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Jun 11, 2024

Fix #237 by replacing the dependency on ColPack.jl with a dependency on SparseMatrixColorings.jl.
Similar to #230, I use the ADTypes.jl coloring framework so that other coloring algorithms can be easily inserted.

In what follows, I'm careful to differentiate between

Upsides

Very relevant:

  • ColPack (C++) is 30k LOCs of unmaintained, unreadable C++ that hasn't been touched in half a decade.
  • SparseMatrixColorings.jl is 1.5k LOCs of maintainable, readable pure Julia with good docs and reliable tests.
  • SparseMatrixColorings.jl seems faster than the upcoming release v0.5 of ColPack.jl, at least for the natural ordering of vertices

A bit less relevant cause it can be fixed with lots of sweat:

Downsides

src/ad.jl Show resolved Hide resolved
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimalControl.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gdalle!

@amontoison amontoison merged commit fb10063 into JuliaSmoothOptimizers:main Jun 11, 2024
32 of 33 checks passed
@tmigot
Copy link
Member

tmigot commented Jun 11, 2024

@amontoison @gdalle Please squash and not rebase, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ColPack with SparseMatrixColorings?
3 participants