Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users configure sparsity detector and coloring algorithm #242

Closed
gdalle opened this issue Jun 6, 2024 · 9 comments
Closed

Let users configure sparsity detector and coloring algorithm #242

gdalle opened this issue Jun 6, 2024 · 9 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jun 6, 2024

See the discussion in #230 (comment)

@amontoison
Copy link
Member

It's already the case. It's a keyword augment of SparseADHessian and SparseADJacobian.
https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/main/src/sparse_hessian.jl#L24

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 6, 2024

Where is it documented? Can't find those in the API reference

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 6, 2024

If it's not documented, users can't know where to change it

@gdalle gdalle changed the title Let users configure sparsity detector Let users configure sparsity detector and coloring algorithm Jun 12, 2024
@gdalle
Copy link
Collaborator Author

gdalle commented Jun 12, 2024

Same goes for the coloring algorithm since #244

@amontoison
Copy link
Member

Let's update everything after that we switch to DifferentiationInterface.jl.

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 14, 2024

Roadmap:

  1. Track down where we inserted the sparsity detector and coloring algorithms in PRs Use SparseConnectivityTracer.jl #230 and Replace ColPack with SparseMatrixColorings #244
  2. Tell users how they can change it

@amontoison
Copy link
Member

amontoison commented Jun 14, 2024

@gdalle I'm wondering if we could not use a symmetric_coloring before rely we rely on DI.jl.
We probably just need to update https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/main/src/sparse_hessian.jl#L208-L216.

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 14, 2024

Yes you can, I outlined how to do it in #246.

@amontoison
Copy link
Member

Done in #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants