Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java 21 #315

Open
wants to merge 27 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1e530c9
more 17 instances ...
baltzell Aug 21, 2024
613b284
goto 21
baltzell Aug 21, 2024
c8a5ce7
more java versions in POMs
baltzell Aug 26, 2024
e2b6a02
Merge branch 'development' into java21
baltzell Aug 26, 2024
5eaae76
cleanup
baltzell Aug 26, 2024
cffe13a
container to 21
baltzell Aug 26, 2024
51b22b6
upgrade groovy version
baltzell Aug 26, 2024
13c3389
use similar path, reduce checks
baltzell Aug 26, 2024
41d62b4
Merge branch 'development' into java21
baltzell Sep 19, 2024
015527e
Merge branch 'development' into java21
baltzell Sep 23, 2024
f91b0db
build(deps): bump org.openjfx:javafx-fxml from 22.0.2 to 23
dependabot[bot] Sep 23, 2024
beae76e
build(deps): bump org.openjfx:javafx-controls from 22.0.2 to 23
dependabot[bot] Sep 23, 2024
1880266
Merge branch 'java21' into dependabot/maven/org.openjfx-javafx-contro…
baltzell Sep 23, 2024
16318d2
Merge branch 'java21' into dependabot/maven/org.openjfx-javafx-fxml-2…
baltzell Sep 23, 2024
6e375fe
Merge remote-tracking branch 'remotes/origin/dependabot/maven/org.ope…
baltzell Sep 24, 2024
daebeb1
Merge branch 'development' into java21
baltzell Sep 24, 2024
70c50e9
build(deps): bump org.openjfx:javafx-fxml from 22.0.2 to 24-ea+5
dependabot[bot] Oct 7, 2024
d4e3960
build(deps): bump org.openjfx:javafx-controls from 22.0.2 to 24-ea+5
dependabot[bot] Oct 7, 2024
b6682de
Merge remote-tracking branch 'origin/dependabot/maven/org.openjfx-jav…
baltzell Oct 7, 2024
845c018
Merge remote-tracking branch 'origin/dependabot/maven/org.openjfx-jav…
baltzell Oct 7, 2024
86ce6a8
Merge branch 'development' into java21
baltzell Oct 26, 2024
cfe515a
Merge branch 'development' into java21
baltzell Nov 6, 2024
db9ca64
Merge branch 'development' into java21
baltzell Dec 14, 2024
c31393f
Merge branch 'development' into java21
c-dilks Dec 16, 2024
9919916
fix(ci): use latest groovy
c-dilks Dec 16, 2024
cb76488
Merge branch 'development' into java21
c-dilks Dec 17, 2024
1705d5e
ci: re-trigger since `clas12-validation` now uses Java 21
c-dilks Dec 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ defaults:
shell: bash

env:
java_version: 17
java_version: 21
java_distribution: zulu
groovy_version: 4.0.3
groovy_version: 4.0
c-dilks marked this conversation as resolved.
Show resolved Hide resolved

jobs:

Expand Down
2 changes: 1 addition & 1 deletion common-tools/clas-geometry/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

</dependency>
<dependency>
<groupId>org.jlab.ccdbrcdb</groupId>
Expand Down
4 changes: 2 additions & 2 deletions common-tools/clas-jcsg/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-fxml</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

</dependency>
<dependency>
<groupId>org.jlab.clas</groupId>
Expand Down
2 changes: 1 addition & 1 deletion common-tools/cnuphys/parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<version>3.13.0</version>
<configuration>
<encoding>UTF-8</encoding>
<release>17</release>
<release>21</release>
</configuration>
</plugin>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion common-tools/coat-lib/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
<version>3.8.0</version>
<configuration>
<encoding>UTF-8</encoding>
<release>17</release>
<release>21</release>
</configuration>
</plugin>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion common-tools/parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<release>17</release>
<release>21</release>
</configuration>
</plugin>
</plugins>
Expand Down
14 changes: 7 additions & 7 deletions install-clara
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,14 @@ do
esac
done

# Check requested installation path:
# Check installation path:
clara_home="$args"
[ "${#args[@]}" -lt 1 ] && error "Missing PATH argument"
[ "${#args[@]}" -lt 1 ] && error "Missing PATH argument."
[ "${#args[@]}" -gt 1 ] && error "Extra PATH arguments: ${args[@]:1}"
[ -e "$clara_home" ] && error "Installation PATH already exists: $clara_home"
mkdir -p $clara_home || error "Cannot create installation PATH: $clara_home"
clara_home=$(cd $clara_home && pwd) && rmdir $clara_home
echo -e "\nConfigured for a CLARA_HOME installation at:\n\t$clara_home"

# Detect local COATJAVA installation and convert into an absolute path:
if compgen -G "$coatjava/lib/clas/coat-libs-*.jar" > /dev/null
Expand All @@ -107,12 +108,11 @@ then
echo -e "\nUsing local COATJAVA installation:\n\t$coatjava"
elif ! [[ "$coatjava" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]
then
echo -e "\n\nWARNING: COATJAVA doesn't look like a local installation nor version number: $coatjava"
echo -e "\nWARNING: COATJAVA doesn't look like a local installation nor version number: $coatjava"
fi

# Do everything inside a new, temporary directory:
[ -w "." ] || error "Current working directory is not writeable: \$PWD=$PWD"
tmp_dir=$(mktemp -d tmp.install-clara.XXXXXX)
tmp_dir=$(mktemp -d $clara_home.tmp.XXXXXX)
[ $? -ne 0 ] && error "Cannot create temporary directory: $tmp_dir"
tmp_dir=$(cd $tmp_dir && pwd)
echo -e "\nCreating temporary build directory:\n\t$tmp_dir"
Expand All @@ -131,15 +131,15 @@ fi
# COATJAVA:
if ! compgen -G "$coatjava/lib/clas/coat-libs-*.jar" > /dev/null
then
echo -e "\nRetrieving COATJAVA version $coatjava ..."
echo -e "\nRetrieving COATJAVA/$coatjava ..."
get https://clasweb.jlab.org/clas12offline/distribution/coatjava/coatjava-$coatjava.tar.gz
coatjava=./coatjava
fi
mkdir -p clara-cre/plugins/clas12/config
cp -Lr $coatjava/etc $coatjava/bin $coatjava/lib* clara-cre/plugins/clas12

# GRAPES:
echo -e "\nRetrieving GRAPES version $grapes ..."
echo -e "\nRetrieving GRAPES/$grapes ..."
get https://clasweb.jlab.org/clas12offline/distribution/grapes/grapes-$grapes.tar.gz
mv grapes-$grapes clara-cre/plugins/grapes
mv -f clara-cre/plugins/grapes/bin/clara-grapes clara-cre/bin/
Expand Down
2 changes: 1 addition & 1 deletion parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<release>17</release>
<release>21</release>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
Expand Down
18 changes: 0 additions & 18 deletions reconstruction/vtx/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,6 @@
<version>11.0.5-SNAPSHOT</version>
</parent>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
</plugins>
</build>

<dependencies>
<dependency>
<groupId>org.jlab.clas</groupId>
Expand All @@ -44,9 +31,4 @@
</dependency>
</dependencies>

<properties>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
</properties>

</project>
Loading