Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java 21 #315

Open
wants to merge 27 commits into
base: development
Choose a base branch
from
Open

java 21 #315

wants to merge 27 commits into from

Conversation

baltzell
Copy link
Collaborator

No description provided.

@baltzell baltzell force-pushed the java21 branch 2 times, most recently from 8ec04d5 to 13c3389 Compare August 26, 2024 17:19
baltzell and others added 7 commits September 19, 2024 23:05
Bumps org.openjfx:javafx-fxml from 22.0.2 to 23.

---
updated-dependencies:
- dependency-name: org.openjfx:javafx-fxml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps org.openjfx:javafx-controls from 22.0.2 to 23.

---
updated-dependencies:
- dependency-name: org.openjfx:javafx-controls
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
baltzell and others added 5 commits September 24, 2024 16:58
Bumps org.openjfx:javafx-fxml from 22.0.2 to 24-ea+5.

---
updated-dependencies:
- dependency-name: org.openjfx:javafx-fxml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps org.openjfx:javafx-controls from 22.0.2 to 24-ea+5.

---
updated-dependencies:
- dependency-name: org.openjfx:javafx-controls
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@c-dilks
Copy link
Member

c-dilks commented Dec 16, 2024

ignore validation pipeline failure, since JeffersonLab/clas12-validation#163 is needed.

@c-dilks
Copy link
Member

c-dilks commented Dec 17, 2024

When you're ready to merge this, let's also merge

@baltzell
Copy link
Collaborator Author

baltzell commented Dec 18, 2024

I don't think either of those (JeffersonLab/clas12-timeline#236, JeffersonLab/clas12-validation#163) really need to wait for this. In some ways, it's better if they go ahead.

@c-dilks
Copy link
Member

c-dilks commented Dec 18, 2024

added to java21 project page: https://github.com/orgs/JeffersonLab/projects/45/views/1

Copy link
Member

@c-dilks c-dilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well bump these to the latest version that @dependabot proposed

</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-fxml</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

@@ -17,12 +17,12 @@
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

@@ -17,7 +17,7 @@
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
<version>22.0.2</version>
<version>24-ea+5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>24-ea+5</version>
<version>24-ea+19</version>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants