added lzma-c branch #6
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| cmake_minimum_required(VERSION 2.8.3 FATAL_ERROR) | ||
| set(CMAKE_VERBOSE_MAKEFILE off) | ||
|
There was a problem hiding this comment. As explained here, line 4, i.e. |
||
|
|
||
| project(lzma) | ||
|
|
||
| file(GLOB HDR_FILES | ||
| ${PROJECT_SOURCE_DIR}/C/*.h) | ||
|
|
||
| file(GLOB SRC_FILES | ||
| ${PROJECT_SOURCE_DIR}/C/*.c) | ||
|
|
||
| add_library(lzma SHARED | ||
| ${SRC_FILES} | ||
| ${HDR_FILES} | ||
| ) | ||
|
|
||
| install( | ||
| TARGETS lzma | ||
| RUNTIME DESTINATION bin | ||
| LIBRARY DESTINATION lib | ||
| ARCHIVE DESTINATION lib | ||
| ) | ||
|
|
||
| install( | ||
| FILES ${HDR_FILES} | ||
| DESTINATION include | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Source: lzma-c | ||
| Version: 19.00 | ||
| Homepage: https://www.7-zip.org/sdk.html | ||
| Description: The LZMA SDK provides the documentation, samples, header files, libraries, and tools you need to develop applications that use LZMA compression. | ||
|
|
||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| lzma Library License | ||
|
There was a problem hiding this comment. You'll need to update this to what we discussed about on Slack 😄 |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
|
|
||
| vcpkg_download_distfile(ARCHIVE | ||
| URLS "https://www.7-zip.org/a/lzma1900.7z" | ||
| FILENAME "lzma-19.00.zip" | ||
| SHA512 60532483249d86960d5c481dc88ebeafabb7e435afb6188bc26f38177b8534ef3da83317d6920d99103d4f10a8dcdb624489ea5ddad8e0c8732bab1bb4ebd7eb | ||
| ) | ||
| vcpkg_extract_source_archive_ex( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| ARCHIVE ${ARCHIVE} | ||
|
There was a problem hiding this comment. As you can see with the syntax highlight, I suggest you rename the variable to Notice that the word "field" is my invention. I use this word to describe keywords used within a CMAKE commande. For insance, on line 13, |
||
| NO_REMOVE_ONE_LEVEL | ||
| PATCHES ${PATCHES} | ||
| ) | ||
| file(COPY ${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt DESTINATION ${SOURCE_PATH}) | ||
|
|
||
| vcpkg_configure_cmake( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| PREFER_NINJA | ||
|
|
||
|
There was a problem hiding this comment. Since this is a semi-pedagogical settings, I'm going to do detail intensive on you 😄 |
||
| ) | ||
|
|
||
|
There was a problem hiding this comment. In the same vein as above, another very pedantic remark: I do not understand here why you changed paragraphs. |
||
| vcpkg_install_cmake() | ||
| vcpkg_copy_pdbs() | ||
|
|
||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | ||
|
|
||
| set(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled) | ||
| set(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled) | ||
|
There was a problem hiding this comment. Why did you enable those 2 settings? |
||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib" "${CURRENT_PACKAGES_DIR}/lib") | ||
|
There was a problem hiding this comment. So Also, this line should go next to line 24 since they are conceptually similar. Actually, why not simply remove the |
||
| configure_file(${CMAKE_CURRENT_LIST_DIR}/LICENSE ${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright COPYONLY) | ||
|
There was a problem hiding this comment. As the sign at the end of this line indicates, |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thing first: I have a compilation error when trying it. Here's the error. I'll let you have fun with it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be a good excuse to install WSL (Windows Subsystem for Linux) if you want to do it 😄