added lzma-c branch #6

JangBoo · 2020-06-18T17:00:19Z

Describe the pull request

What does your PR fix? Fixes #
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?

JangBoo · 2020-06-18T17:05:10Z

@klalumiere
Can you review this code?

klalumiere

As I was telling you the other day, don't worry about the long review: I always find a lot of things to say! 😄 .

klalumiere · 2020-06-19T00:37:57Z

ports/lzma-c/CMakeLists.txt

@@ -0,0 +1,27 @@
+cmake_minimum_required(VERSION 2.8.3 FATAL_ERROR)


First thing first: I have a compilation error when trying it. Here's the error. I'll let you have fun with it 😄

[1/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zBuf.c.o -MF CMakeFiles/lzma.dir/C/7zBuf.c.o.d -o CMakeFiles/lzma.dir/C/7zBuf.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zBuf.c [2/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zCrcOpt.c.o -MF CMakeFiles/lzma.dir/C/7zCrcOpt.c.o.d -o CMakeFiles/lzma.dir/C/7zCrcOpt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zCrcOpt.c [3/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zCrc.c.o -MF CMakeFiles/lzma.dir/C/7zCrc.c.o.d -o CMakeFiles/lzma.dir/C/7zCrc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zCrc.c [4/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zBuf2.c.o -MF CMakeFiles/lzma.dir/C/7zBuf2.c.o.d -o CMakeFiles/lzma.dir/C/7zBuf2.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zBuf2.c [5/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/AesOpt.c.o -MF CMakeFiles/lzma.dir/C/AesOpt.c.o.d -o CMakeFiles/lzma.dir/C/AesOpt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/AesOpt.c [6/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zStream.c.o -MF CMakeFiles/lzma.dir/C/7zStream.c.o.d -o CMakeFiles/lzma.dir/C/7zStream.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zStream.c [7/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zDec.c.o -MF CMakeFiles/lzma.dir/C/7zDec.c.o.d -o CMakeFiles/lzma.dir/C/7zDec.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zDec.c [8/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Aes.c.o -MF CMakeFiles/lzma.dir/C/Aes.c.o.d -o CMakeFiles/lzma.dir/C/Aes.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Aes.c [9/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zFile.c.o -MF CMakeFiles/lzma.dir/C/7zFile.c.o.d -o CMakeFiles/lzma.dir/C/7zFile.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zFile.c [10/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zAlloc.c.o -MF CMakeFiles/lzma.dir/C/7zAlloc.c.o.d -o CMakeFiles/lzma.dir/C/7zAlloc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zAlloc.c [11/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Alloc.c.o -MF CMakeFiles/lzma.dir/C/Alloc.c.o.d -o CMakeFiles/lzma.dir/C/Alloc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Alloc.c [12/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/7zArcIn.c.o -MF CMakeFiles/lzma.dir/C/7zArcIn.c.o.d -o CMakeFiles/lzma.dir/C/7zArcIn.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/7zArcIn.c [13/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Bra86.c.o -MF CMakeFiles/lzma.dir/C/Bra86.c.o.d -o CMakeFiles/lzma.dir/C/Bra86.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Bra86.c [14/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Bcj2.c.o -MF CMakeFiles/lzma.dir/C/Bcj2.c.o.d -o CMakeFiles/lzma.dir/C/Bcj2.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Bcj2.c [15/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/BraIA64.c.o -MF CMakeFiles/lzma.dir/C/BraIA64.c.o.d -o CMakeFiles/lzma.dir/C/BraIA64.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/BraIA64.c [16/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Bcj2Enc.c.o -MF CMakeFiles/lzma.dir/C/Bcj2Enc.c.o.d -o CMakeFiles/lzma.dir/C/Bcj2Enc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Bcj2Enc.c [17/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Bra.c.o -MF CMakeFiles/lzma.dir/C/Bra.c.o.d -o CMakeFiles/lzma.dir/C/Bra.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Bra.c [18/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Delta.c.o -MF CMakeFiles/lzma.dir/C/Delta.c.o.d -o CMakeFiles/lzma.dir/C/Delta.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Delta.c [19/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/DllSecur.c.o -MF CMakeFiles/lzma.dir/C/DllSecur.c.o.d -o CMakeFiles/lzma.dir/C/DllSecur.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/DllSecur.c [20/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/CpuArch.c.o -MF CMakeFiles/lzma.dir/C/CpuArch.c.o.d -o CMakeFiles/lzma.dir/C/CpuArch.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/CpuArch.c [21/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/LzFindMt.c.o -MF CMakeFiles/lzma.dir/C/LzFindMt.c.o.d -o CMakeFiles/lzma.dir/C/LzFindMt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c FAILED: CMakeFiles/lzma.dir/C/LzFindMt.c.o /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/LzFindMt.c.o -MF CMakeFiles/lzma.dir/C/LzFindMt.c.o.d -o CMakeFiles/lzma.dir/C/LzFindMt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:8: In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.h:8: /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:15:22: error: unknown type name 'HANDLE' WRes HandlePtr_Close(HANDLE *h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:16:24: error: unknown type name 'HANDLE' WRes Handle_WaitObject(HANDLE h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:18:9: error: unknown type name 'HANDLE' typedef HANDLE CThread; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:35:55: error: unknown type name 'LPVOID' WRes Thread_Create(CThread *p, THREAD_FUNC_TYPE func, LPVOID param); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:37:9: error: unknown type name 'HANDLE' typedef HANDLE CEvent; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:51:9: error: unknown type name 'HANDLE' typedef HANDLE CSemaphore; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:60:9: error: unknown type name 'CRITICAL_SECTION' typedef CRITICAL_SECTION CCriticalSection; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:15:3: warning: incompatible pointer to integer conversion assigning to 'CThread' (aka 'int') from 'void *' [-Wint-conversion] Thread_Construct(&p->thread); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:19:34: note: expanded from macro 'Thread_Construct' #define Thread_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:16:3: warning: incompatible pointer to integer conversion assigning to 'CAutoResetEvent' (aka 'int') from 'void *' [-Wint-conversion] Event_Construct(&p->canStart); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:40:33: note: expanded from macro 'Event_Construct' #define Event_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:17:3: warning: incompatible pointer to integer conversion assigning to 'CAutoResetEvent' (aka 'int') from 'void *' [-Wint-conversion] Event_Construct(&p->wasStarted); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:40:33: note: expanded from macro 'Event_Construct' #define Event_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:18:3: warning: incompatible pointer to integer conversion assigning to 'CAutoResetEvent' (aka 'int') from 'void *' [-Wint-conversion] Event_Construct(&p->wasStopped); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:40:33: note: expanded from macro 'Event_Construct' #define Event_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:19:3: warning: incompatible pointer to integer conversion assigning to 'CSemaphore' (aka 'int') from 'void *' [-Wint-conversion] Semaphore_Construct(&p->freeSemaphore); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:52:37: note: expanded from macro 'Semaphore_Construct' #define Semaphore_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:20:3: warning: incompatible pointer to integer conversion assigning to 'CSemaphore' (aka 'int') from 'void *' [-Wint-conversion] Semaphore_Construct(&p->filledSemaphore); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:52:37: note: expanded from macro 'Semaphore_Construct' #define Semaphore_Construct(p) *(p) = NULL ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:41:5: warning: implicit declaration of function 'LeaveCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Leave(&p->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:64:34: note: expanded from macro 'CriticalSection_Leave' #define CriticalSection_Leave(p) LeaveCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:47:3: warning: implicit declaration of function 'EnterCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Enter(&p->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:63:34: note: expanded from macro 'CriticalSection_Enter' #define CriticalSection_Enter(p) EnterCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:56:8: warning: comparison between pointer and integer ('CThread' (aka 'int') and 'void *') [-Wpointer-integer-compare] if (!Thread_WasCreated(&p->thread) || p->needStart) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:20:36: note: expanded from macro 'Thread_WasCreated' #define Thread_WasCreated(p) (*(p) != NULL) ~~~~ ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:61:5: warning: implicit declaration of function 'LeaveCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Leave(&p->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:64:34: note: expanded from macro 'CriticalSection_Leave' #define CriticalSection_Leave(p) LeaveCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:78:7: warning: comparison between pointer and integer ('CThread' (aka 'int') and 'void *') [-Wpointer-integer-compare] if (Thread_WasCreated(&p->thread)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:20:36: note: expanded from macro 'Thread_WasCreated' #define Thread_WasCreated(p) (*(p) != NULL) ~~~~ ^ ~~~~ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:89:5: warning: implicit declaration of function 'DeleteCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Delete(&p->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:62:35: note: expanded from macro 'CriticalSection_Delete' #define CriticalSection_Delete(p) DeleteCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:178:11: warning: implicit declaration of function 'EnterCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Enter(&mt->btSync.cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:63:34: note: expanded from macro 'CriticalSection_Enter' #define CriticalSection_Enter(p) EnterCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:188:11: warning: implicit declaration of function 'LeaveCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Leave(&mt->btSync.cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:64:34: note: expanded from macro 'CriticalSection_Leave' #define CriticalSection_Leave(p) LeaveCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:431:5: warning: implicit declaration of function 'EnterCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Enter(&sync->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:63:34: note: expanded from macro 'CriticalSection_Enter' #define CriticalSection_Enter(p) EnterCriticalSection(p) ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFindMt.c:446:5: warning: implicit declaration of function 'LeaveCriticalSection' is invalid in C99 [-Wimplicit-function-declaration] CriticalSection_Leave(&sync->cs); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:64:34: note: expanded from macro 'CriticalSection_Leave' #define CriticalSection_Leave(p) LeaveCriticalSection(p) ^ 16 warnings and 7 errors generated. [22/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o -MF CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o.d -o CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2DecMt.c FAILED: CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o -MF CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o.d -o CMakeFiles/lzma.dir/C/Lzma2DecMt.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2DecMt.c In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2DecMt.c:30: In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/MtDec.h:10: /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:15:22: error: unknown type name 'HANDLE' WRes HandlePtr_Close(HANDLE *h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:16:24: error: unknown type name 'HANDLE' WRes Handle_WaitObject(HANDLE h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:18:9: error: unknown type name 'HANDLE' typedef HANDLE CThread; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:35:55: error: unknown type name 'LPVOID' WRes Thread_Create(CThread *p, THREAD_FUNC_TYPE func, LPVOID param); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:37:9: error: unknown type name 'HANDLE' typedef HANDLE CEvent; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:51:9: error: unknown type name 'HANDLE' typedef HANDLE CSemaphore; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:60:9: error: unknown type name 'CRITICAL_SECTION' typedef CRITICAL_SECTION CCriticalSection; ^ 7 errors generated. [23/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma2Enc.c.o -MF CMakeFiles/lzma.dir/C/Lzma2Enc.c.o.d -o CMakeFiles/lzma.dir/C/Lzma2Enc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2Enc.c FAILED: CMakeFiles/lzma.dir/C/Lzma2Enc.c.o /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma2Enc.c.o -MF CMakeFiles/lzma.dir/C/Lzma2Enc.c.o.d -o CMakeFiles/lzma.dir/C/Lzma2Enc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2Enc.c In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2Enc.c:13: In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/MtCoder.h:7: In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/MtDec.h:10: /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:15:22: error: unknown type name 'HANDLE' WRes HandlePtr_Close(HANDLE *h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:16:24: error: unknown type name 'HANDLE' WRes Handle_WaitObject(HANDLE h); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:18:9: error: unknown type name 'HANDLE' typedef HANDLE CThread; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:35:55: error: unknown type name 'LPVOID' WRes Thread_Create(CThread *p, THREAD_FUNC_TYPE func, LPVOID param); ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:37:9: error: unknown type name 'HANDLE' typedef HANDLE CEvent; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:51:9: error: unknown type name 'HANDLE' typedef HANDLE CSemaphore; ^ /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Threads.h:60:9: error: unknown type name 'CRITICAL_SECTION' typedef CRITICAL_SECTION CCriticalSection; ^ In file included from /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2Enc.c:13: /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/MtCoder.h:110:5: error: unknown type name 'LONG' LONG numFinishedThreads; ^ 8 errors generated. [24/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma86Dec.c.o -MF CMakeFiles/lzma.dir/C/Lzma86Dec.c.o.d -o CMakeFiles/lzma.dir/C/Lzma86Dec.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma86Dec.c [25/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma2Dec.c.o -MF CMakeFiles/lzma.dir/C/Lzma2Dec.c.o.d -o CMakeFiles/lzma.dir/C/Lzma2Dec.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma2Dec.c [26/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/LzFind.c.o -MF CMakeFiles/lzma.dir/C/LzFind.c.o.d -o CMakeFiles/lzma.dir/C/LzFind.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzFind.c [27/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/Lzma86Enc.c.o -MF CMakeFiles/lzma.dir/C/Lzma86Enc.c.o.d -o CMakeFiles/lzma.dir/C/Lzma86Enc.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/Lzma86Enc.c [28/46] /usr/bin/cc -fPIC -g -MD -MT CMakeFiles/lzma.dir/C/LzmaDec.c.o -MF CMakeFiles/lzma.dir/C/LzmaDec.c.o.d -o CMakeFiles/lzma.dir/C/LzmaDec.c.o -c /home/klalumiere/Projects/vcpkg-jangboo/buildtrees/lzma/src/lzma-19-a5ec4f69c5/C/LzmaDec.c ninja: build stopped: subcommand failed.

That might be a good excuse to install WSL (Windows Subsystem for Linux) if you want to do it 😄

klalumiere · 2020-06-19T00:40:05Z

ports/lzma-c/CMakeLists.txt

@@ -0,0 +1,27 @@
+cmake_minimum_required(VERSION 2.8.3 FATAL_ERROR)
+set(CMAKE_VERBOSE_MAKEFILE off)


As explained here, line 4, i.e. project(lzma), initialize this variable to false <=> off. Hence, you do not need this line.

klalumiere · 2020-06-19T00:41:01Z

ports/lzma-c/LICENSE

@@ -0,0 +1 @@
+lzma Library License


You'll need to update this to what we discussed about on Slack 😄

klalumiere · 2020-06-19T00:47:20Z

ports/lzma-c/portfile.cmake

+)
+vcpkg_extract_source_archive_ex(
+    OUT_SOURCE_PATH SOURCE_PATH
+    ARCHIVE ${ARCHIVE}


As you can see with the syntax highlight, ARCHIVE in capital letters in not a very good variable name because it is also a field name. In other words, here, you have the "field" ARCHIVE in red, and then you take the content of the ARCHIVE variable with ${ARCHIVE}. This is all very confusing (actually, I would not be surprised if you need to reread this paragraph many times 😆 .

I suggest you rename the variable to lzmaArchive. You'll also need to change it at line 2. Notice that, at line 2, you (most likely) meat to use the ARCHIVE variable, but the syntax highlight gets confused and thinks you're making a reference to the "field" ARCHIVE.

Notice that the word "field" is my invention. I use this word to describe keywords used within a CMAKE commande. For insance, on line 13, COPY and DESTINATION would be "field" of the file command according to my nomemclature. Likewise, SOURCE_PATH and PREFER_NINJA would be "fields" of vcpkg_configure_cmake.

klalumiere · 2020-06-19T00:52:49Z

ports/lzma-c/portfile.cmake

+vcpkg_configure_cmake(
+    SOURCE_PATH ${SOURCE_PATH}
+    PREFER_NINJA 
+


Since this is a semi-pedagogical settings, I'm going to do detail intensive on you 😄
I don't think you need this empty line here, except if you're trying to communicate something. In general, each decision you take into the code should aim to communicate something to both the machine and the other developers that will read the code 🤓 .

klalumiere · 2020-06-19T00:53:23Z

ports/lzma-c/portfile.cmake

+    PREFER_NINJA 
+
+)
+


In the same vein as above, another very pedantic remark: I do not understand here why you changed paragraphs.

klalumiere · 2020-06-19T01:14:18Z

ports/lzma-c/portfile.cmake

+file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
+
+set(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
+set(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled)


Why did you enable those 2 settings?

klalumiere · 2020-06-19T01:16:53Z

ports/lzma-c/portfile.cmake

+
+set(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
+set(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled)
+file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib" "${CURRENT_PACKAGES_DIR}/lib")


So lzma builds the release and debug libraries at the same time, is this right? If so, is there a setting in vcpkg that allows to say "I want the debug libraries" or "I want the release librarie"? If yes, we should use it.

Also, this line should go next to line 24 since they are conceptually similar. Actually, why not simply remove the ${CURRENT_PACKAGES_DIR}/debug directory?

klalumiere · 2020-06-19T01:19:48Z

ports/lzma-c/portfile.cmake

+set(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
+set(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled)
+file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib" "${CURRENT_PACKAGES_DIR}/lib")
+configure_file(${CMAKE_CURRENT_LIST_DIR}/LICENSE ${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright COPYONLY)


As the sign at the end of this line indicates, no new line at the end of file. This is important on *Nix system, like Linux and macOS: every text file should end with an empty line, because a lot of useful tools assume this is the case.

JangBoo added 2 commits June 18, 2020 12:51

added lzma-c branch

afe7509

edited Captial letter to small

9f1769b

klalumiere suggested changes Jun 19, 2020

View reviewed changes

JangBoo and others added 6 commits June 19, 2020 10:14

Edited CONTROL and portfile

c48c83a

Edited cmakelist to make lib instead of dll

433792e

Added vcpkg_fail_port_install()

c962a26

reverted an edit

477e04c

Edited portfile and cmake

5477c18

edited cmakelist to make it work in linux

1559997

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added lzma-c branch #6

added lzma-c branch #6

JangBoo commented Jun 18, 2020

JangBoo commented Jun 18, 2020 •

edited

Loading

klalumiere left a comment

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

klalumiere Jun 19, 2020

		@@ -0,0 +1,27 @@
		cmake_minimum_required(VERSION 2.8.3 FATAL_ERROR)

		@@ -0,0 +1,27 @@
		cmake_minimum_required(VERSION 2.8.3 FATAL_ERROR)
		set(CMAKE_VERBOSE_MAKEFILE off)

added lzma-c branch #6

Are you sure you want to change the base?

added lzma-c branch #6

Conversation

JangBoo commented Jun 18, 2020

JangBoo commented Jun 18, 2020 • edited Loading

klalumiere left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JangBoo commented Jun 18, 2020 •

edited

Loading