Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions #532

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

timostrunk
Copy link

Description:

PR #531 showed that all github actions (CI, docs and pre-commit) are currently broken.

  • Docs are broken, because the environment is pulling in a broken jinja version incompatible with the ancient sphinx version
    Solution -> switch to a mamba action and pin jinja
  • pre-commit is broken out of many reasons, mainly due to the conda setup
    Solution -> update github actions, run isort with black profile, pray
  • CI is broken because of python 3.7 and old pyarrow versions.
    Solution -> Remove python 3.7 and old pyarrow tests
    The unit test changes are also included in this PR. I will rebase Move to minimalkv #531, once this is merged to get the actions green in Move to minimalkv #531.

This PR is more a bandaid than anything else. A good fix would be to rebuild the github actions, update sphinx, update dependabot and update all environments.

Todo:

  • Check the two commits actually changing funtionality
  • Confirm that dropping Py3.7 and old pyarrow from CI is ok (was broken before anyways)

@timostrunk timostrunk mentioned this pull request Nov 4, 2022
5 tasks
@timostrunk timostrunk force-pushed the fix_github_actions branch 3 times, most recently from 7414a57 to 733962a Compare November 5, 2022 12:53
@timostrunk
Copy link
Author

Still fighting with the CI tests. After removing every CI test with pyarrow < 2.0.0, failing tests are pyarrow==5.0.0 and pyarrow==2.0.0 and numfocus nightly.

…lack to be compatible with updated actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant