Move to minimalkv #531
Open
Move to minimalkv #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lack to be compatible with updated actions.
timostrunk
force-pushed
the
move_to_minimalkv
branch
from
a9b8fd2 to
6856c5c
Compare
|
We implemented this over in data-engineering-collective/plateau#51 as we didn't get anyone to respond here anymore. Happy to collaborate with you there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some time ago in #462 it was discussed that a move to minimalkv is not required as repo access to simplekv will be transfered. As of today the simplekv repository is dead. This is therefore another attempt to move kartothek to minimalkv. I recreated the previous PR as the codebase has changed a bit since the last PR.
Still, this PR should also be credited to @xhochy , because he basically did the same work some time ago.
Functionally nothing should change as minimalkv stores and storefact api are unchanged between the two packages.
Consumers of kartothek will be able to have both minimalkv and storefact and simplekv in the same python environment and use them interchangeably. This PR allows those projects to switch to minimalkv and abandon simplekv gracefully.
The two additional commits part of this PR should be reviewed very carefully: I added them to fix unit tests before starting development. Especially the added type compatibility in serialization/_generic should be reviewed very carefully.