Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize package meta #349

Merged
merged 3 commits into from
May 2, 2024
Merged

Organize package meta #349

merged 3 commits into from
May 2, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 30, 2024 •
edited
Loading

Set proper pyproject.toml, so that wheel package have all the proper dependencies list. Use this dependency list in conda-build meta.yaml to avoid duplicates and keep conda and wheel dependencies consistent.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Apr 30, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/organize_package_meta branch 4 times, most recently from 2bbf32b to 19ac1df Compare May 1, 2024 19:19
@ZzEeKkAa ZzEeKkAa force-pushed the feature/organize_package_meta branch 10 times, most recently from a4a50a5 to be187ae Compare May 1, 2024 21:19
@ZzEeKkAa ZzEeKkAa force-pushed the feature/organize_package_meta branch from be187ae to 6542b52 Compare May 2, 2024 13:39
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 2, 2024 14:01
@ZzEeKkAa ZzEeKkAa requested review from adarshyoga and diptorupd May 2, 2024 14:01
@ZzEeKkAa ZzEeKkAa merged commit 71c1061 into main May 2, 2024
71 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/organize_package_meta branch May 2, 2024 14:25
@ZzEeKkAa ZzEeKkAa mentioned this pull request May 2, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@adarshyoga adarshyoga Awaiting requested review from adarshyoga

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd