Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dpbench conda dep on python #350

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented May 2, 2024

#349 removed python package dependency from conda run dependencies that resulted in similar package name generation regardless on the python version.

Thank you @adarshyoga for the report!

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa requested a review from adarshyoga May 2, 2024 22:21
@ZzEeKkAa ZzEeKkAa self-assigned this May 2, 2024
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 3, 2024 00:00
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 3, 2024 00:00
@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented May 3, 2024

Confirmed, that the filename now contains python version: dpbench-0.2.0-py311h852cfe9_85.tar.bz2

@adarshyoga adarshyoga merged commit 2838206 into main May 3, 2024
71 checks passed
@adarshyoga adarshyoga deleted the fix/conda-package-upload branch May 3, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants