-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert redirects #79
Assert redirects #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible and I like it! I haven't gone through it in details yet though. So I'll leave it for someone else to official approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Thanks for expanding out test coverage. I've suggested a few minor simplifications.
Co-authored-by: Christopher Cave-Ayland <[email protected]>
Co-authored-by: Christopher Cave-Ayland <[email protected]>
All good! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
============================================
+ Coverage 82.00% 100.00% +18.00%
============================================
Files 6 5 -1
Lines 50 41 -9
============================================
Hits 41 41
+ Misses 9 0 -9 ☔ View full report in Codecov by Sentry. |
100% coverage!!! 🎉 🎉 |
Description
Adds base test classes - and then actual test classes - to assert the page redirection when visiting views that require authentication.
Fixes #69
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks