Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #77

Closed
cc-a opened this issue Sep 16, 2024 · 5 comments
Closed

Improve test coverage #77

cc-a opened this issue Sep 16, 2024 · 5 comments
Assignees
@jamesturner246 @TinyMarsh @alexdewar

Comments

@cc-a
Copy link
Contributor

cc-a commented Sep 16, 2024

No description provided.

@jamesturner246
Copy link
Contributor

Just want to confirm if there's any specific areas you want efforts focused on, or just more coverage in general?

@cc-a
Copy link
Contributor Author

cc-a commented Sep 18, 2024

Would be good to make sure we're covering all of the view functions with appropriate authentication/permission checks.

@alexdewar
Copy link
Contributor

It looks like @dalonsoa's PR #79 raises the coverage to 82% overall. Every file except _production.py has 100% coverage.

I think this is good enough for now so I suggest we close this.

@cc-a
Copy link
Contributor Author

cc-a commented Sep 19, 2024

Could configure _production.py to be ignored as by it's nature it wouldn't be covered by tests?

@alexdewar
Copy link
Contributor

Good idea. Maybe you could do this in your PR @dalonsoa?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesturner246 jamesturner246

@TinyMarsh TinyMarsh

@alexdewar alexdewar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jamesturner246 @TinyMarsh @cc-a @alexdewar