Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update download instructions to use idc-index #1399

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

fedorov
Copy link
Member

@fedorov fedorov commented Jul 11, 2024

No description provided.

@fedorov
Copy link
Member Author

fedorov commented Jul 11, 2024

@s-paquette can you also please update the manifest generation part to have the following for the header:

# To download the files in this manifest, first install idc-index python 
# package (https://github.com/ImagingDataCommons/idc-index),
# then run the following command:
#
#   idc download manifest.s5cmd
#
# See IDC documentation for more details: https://learn.canceridc.dev/data/downloading-data
#

@fedorov fedorov marked this pull request as draft July 12, 2024 16:17
@fedorov
Copy link
Member Author

fedorov commented Jul 12, 2024

Right now, as discovered by @bcli4d, the revised instructions will not allow download of items from the previous data versions of IDC, that are not available in the current version, which is a regression relative to the pure s5cmd-based approach. It is probably better to wait for the resolution of ImagingDataCommons/idc-index#100 before this is merged.

@fedorov fedorov marked this pull request as ready for review August 27, 2024 14:09
@fedorov fedorov added this to the Release 44 milestone Aug 27, 2024
@s-paquette s-paquette merged commit a1800a1 into master Aug 27, 2024
1 check passed
@s-paquette s-paquette deleted the update-download-instructions branch November 19, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants