Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace link to s5cmd with the link to the install instructions in the download manifest popup #1284

Open
fedorov opened this issue Sep 13, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@fedorov
Copy link
Member

fedorov commented Sep 13, 2023

For those who are not developers, it may be helpful to have this link instead of the s5cmd github repo pointer, which we have right now: https://github.com/peak/s5cmd#installation.

@fedorov fedorov added enhancement New feature or request triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone labels Sep 13, 2023
@G-White-ISB G-White-ISB added In Progress and removed triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone labels Nov 8, 2023
@G-White-ISB G-White-ISB added this to the Release 40 milestone Nov 8, 2023
@s-paquette s-paquette added testing needed Functionality is available in idc-dev for testing merged:dev Merged into the developement tier labels Nov 9, 2023
@pgundluru
Copy link
Collaborator

Updated link in study and series export like below
image

@pgundluru pgundluru added the testing passed Functionality works as expected on the testing tier label Nov 10, 2023
@fedorov fedorov closed this as completed Nov 11, 2023
@pgundluru
Copy link
Collaborator

@fedorov Sorry to open this back up, Did you also want the manifest themselves to have the link changed? For example in the below image the link still points to s5cmd Github?
image

@pgundluru pgundluru reopened this Nov 13, 2023
@fedorov
Copy link
Member Author

fedorov commented Nov 13, 2023

Yes, makes sense to point that to the installation instructions!

@s-paquette
Copy link
Member

Since this is a backend change (files are constructed and then passed up to the front end) and we're close to release I'd like to bump this to release 41.

@s-paquette s-paquette modified the milestones: Release 40, Release 41 / v17 Nov 13, 2023
@s-paquette s-paquette removed testing needed Functionality is available in idc-dev for testing testing passed Functionality works as expected on the testing tier labels Nov 13, 2023
@G-White-ISB G-White-ISB added testing needed in production Can only be tested once in the production tier and removed In Progress labels Jan 12, 2024
@s-paquette s-paquette removed merged:dev Merged into the developement tier testing needed in production Can only be tested once in the production tier labels Mar 21, 2024
@s-paquette s-paquette modified the milestones: Release 41, Release 42 Mar 21, 2024
@s-paquette s-paquette self-assigned this Apr 26, 2024
@fedorov
Copy link
Member Author

fedorov commented Aug 27, 2024

This is related to #1399.

Now that the download instructions have been revised, the header should be the following:

# To download the files in this manifest, first install idc-index python 
# package (https://github.com/ImagingDataCommons/idc-index),
# then run the following command:
#
#   idc download manifest.s5cmd
#
# See IDC documentation for more details: https://learn.canceridc.dev/data/downloading-data
#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants