Skip to content
This repository has been archived by the owner on Apr 16, 2018. It is now read-only.

fix documentation for install_mailutils #204

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix documentation for install_mailutils #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5aa7a
fix documentation for install_mailutils
LorenzBischof May 5, 2016
fb0cae8
remove unused install_mail_utils_package variable
LorenzBischof May 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,12 @@ class { 'icinga2':

**`mail` binaries**

If you would like to install packages to make a `mail` command binary available so that Icinga 2 can send out email notifications, set the `install_mail_utils_package` parameter to **true**:
Packages that are needed so that Icinga 2 can send out email notifications, are automatically installed. If you would like to prevent this, set the `install_mailutils` parameter to **false**:

<pre>
class { 'icinga2':
...
install_mail_utils_package => true,
install_mailutils => false,
...
}
</pre>
Expand Down
3 changes: 0 additions & 3 deletions manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
#Whether to install the plugin packages when the icinga2 class is applied:
$install_nagios_plugins = true

#whether to install packages that provide the 'mail' binary
$install_mail_utils_package = false

$config_template = 'icinga2/icinga2.conf.erb'
$manage_service = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a documentation change as the commit suggests. What is this change here to address?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be leftover code from a rename of the parameter. It doesn't get used anywhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be a separate commit in my opinion.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'll seperate it, when I'm at a computer.

On Tue, 3 May 2016, 21:52 Zach Leslie, [email protected] wrote:

In manifests/params.pp
voxpupuli/puppet-icinga2#204 (comment):

@@ -21,9 +21,6 @@
#Whether to install the plugin packages when the icinga2 class is applied:
$install_nagios_plugins = true

  • #whether to install packages that provide the 'mail' binary
  • $install_mail_utils_package = false

This change should be a separate commit in my opinion.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Icinga/puppet-icinga2/pull/204/files/68275a92606bdeb4e3bdc1891bb114be42c26163#r61944309


Expand Down