fix documentation for install_mailutils #204
Conversation
| @@ -21,9 +21,6 @@ | |||
| #Whether to install the plugin packages when the icinga2 class is applied: | |||
| $install_nagios_plugins = true | |||
|
|
|||
| #whether to install packages that provide the 'mail' binary | |||
| $install_mail_utils_package = false | |||
There was a problem hiding this comment.
This isn't a documentation change as the commit suggests. What is this change here to address?
There was a problem hiding this comment.
It seems to be leftover code from a rename of the parameter. It doesn't get used anywhere else.
There was a problem hiding this comment.
This change should be a separate commit in my opinion.
There was a problem hiding this comment.
I agree. I'll seperate it, when I'm at a computer.
On Tue, 3 May 2016, 21:52 Zach Leslie, [email protected] wrote:
In manifests/params.pp
voxpupuli/puppet-icinga2#204 (comment):@@ -21,9 +21,6 @@
#Whether to install the plugin packages when the icinga2 class is applied:
$install_nagios_plugins = true
- #whether to install packages that provide the 'mail' binary
- $install_mail_utils_package = false
This change should be a separate commit in my opinion.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Icinga/puppet-icinga2/pull/204/files/68275a92606bdeb4e3bdc1891bb114be42c26163#r61944309
|
Ok, I seperated my changes into two commits. |
|
+1 Would merge. |
The documentation for the parameter to install
mailpackages was wrong. It also wasn't clear if the default is true or not.