Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update state when patching node #6970

Merged

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 16, 2024

What do these changes do?

Whenever node's inputs are changed, the real state is calculated and returned back as message over WebSocket.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Dec 16, 2024
@giancarloromeo giancarloromeo added the bug buggy, it does not work as expected label Dec 16, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (848339f) to head (9b8ed1d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (848339f) and HEAD (9b8ed1d). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (848339f) HEAD (9b8ed1d)
unittests 30 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6970      +/-   ##
==========================================
- Coverage   88.11%   82.23%   -5.89%     
==========================================
  Files        1592      632     -960     
  Lines       62335    30618   -31717     
  Branches     2012      262    -1750     
==========================================
- Hits        54928    25179   -29749     
+ Misses       7071     5379    -1692     
+ Partials      336       60     -276     
Flag Coverage Δ
integrationtests 64.99% <0.00%> (-0.01%) ⬇️
unittests 86.28% <100.00%> (-0.06%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.78% <ø> (-12.63%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.74% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848339f...9b8ed1d. Read the comment docs.

@giancarloromeo giancarloromeo added the a:webserver issue related to the webserver service label Dec 16, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review December 16, 2024 12:07
@giancarloromeo giancarloromeo enabled auto-merge (squash) December 16, 2024 12:20
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. thanks!

@giancarloromeo giancarloromeo merged commit 088192c into ITISFoundation:master Dec 16, 2024
89 of 93 checks passed
@giancarloromeo giancarloromeo deleted the is1811/out-of-date-nodes branch December 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of date nodes
3 participants