Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date nodes #1811

Closed
1 task done
odeimaiz opened this issue Dec 5, 2024 · 5 comments · Fixed by ITISFoundation/osparc-simcore#6970
Closed
1 task done

Out of date nodes #1811

odeimaiz opened this issue Dec 5, 2024 · 5 comments · Fixed by ITISFoundation/osparc-simcore#6970
Assignees
Labels
Feedback Feedback through frontend type:bug Issue that prevents to perform a certain task, features that don't work as t
Milestone

Comments

@odeimaiz
Copy link
Member

odeimaiz commented Dec 5, 2024

If the inputs of a computational node that has been executed change, the state of the node would change from "Success" to "modified".

At some point (I guess with PATCH node), we lost this feature and therefore the frontend can't paint the nodes and edges that are out of date orange. We need to bring back a mechanism to let the backend notify the frontend about changes in the states.

PR when this was implemented:
ITISFoundation/osparc-simcore#2153

Currently:
OutOfDate

After reloading, the status is fetched:
Reload

Event Horizon

Preview Give feedback
  1. a:webserver bug
    giancarloromeo
@odeimaiz odeimaiz added type:bug Issue that prevents to perform a certain task, features that don't work as t Feedback Feedback through frontend labels Dec 5, 2024
@sanderegg
Copy link
Member

@odeimaiz thanks for putting that one in, I just found out also the same.
when you press the run pipeline, then the correct painting is set

@sanderegg
Copy link
Member

might also have to do with: ITISFoundation/osparc-simcore#6910

@odeimaiz
Copy link
Member Author

odeimaiz commented Dec 5, 2024

I believe the reason is that when the backend is running a pipeline, it keeps the frontend updated with websocket messages (nodeUpdated). Since we introduced the PATCH, the frontend patches, but it doesn't get an updated state in the response, hence the status of the outputs get outdated.

@sanderegg
Copy link
Member

This entry might be linked: ITISFoundation/osparc-simcore#6505

@giancarloromeo
Copy link

giancarloromeo commented Dec 16, 2024

@odeimaiz this one only fixes the problem whenever inputs are changed.
For the outputs, please refer to this other one: #6963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback through frontend type:bug Issue that prevents to perform a certain task, features that don't work as t
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants