-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api: user's privacy settings #6904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6904 +/- ##
==========================================
+ Coverage 88.36% 89.32% +0.96%
==========================================
Files 1569 1382 -187
Lines 61555 55057 -6498
Branches 1987 1019 -968
==========================================
- Hits 54390 49181 -5209
+ Misses 6830 5699 -1131
+ Partials 335 177 -158
Continue to review full report in Codecov by Sentry.
|
f4ef677
to
654febf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_webserver/users.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/users.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/users.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci
6eb5898
to
d16e923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks a lot
Quality Gate passedIssues Measures |
What do these changes do?
This PR introduces a draft for implementing privacy controls for user profiles. Key points include:
Default Privacy Settings:
User-Controlled Privacy Settings:
GET /me
(orget_my_profile
)PATCH /me
(orupdate_my_profile
)Upcoming Enhancements: (next PR)
GET /groups/{organization_id}/users
) will respect individual privacy settings.This approach ensures user control over their data while streamlining identifiers within the platform.
NOTE to reviewers: This plugin is outdated. This PR intentionally focuses on creating a functional draft without applying any refactoring at this stage. Comprehensive refactoring will be addressed in subsequent PRs.
Highlights
get_my_profile
returns now username and privacy settings section. It also deprecategravatar_id
update_my_profile
is now PATCH and allows changing alsouserName
Related issue/s
How to test
Driving tests
Dev-ops
None