Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share resources typing the email address #1779

Open
4 of 7 tasks
odeimaiz opened this issue Nov 8, 2024 · 3 comments
Open
4 of 7 tasks

Share resources typing the email address #1779

odeimaiz opened this issue Nov 8, 2024 · 3 comments
Assignees
Labels
PO issue Created by Product owners
Milestone

Comments

@odeimaiz
Copy link
Member

odeimaiz commented Nov 8, 2024

User Story

  • Public Profile preference (be reachable via email. enabled or disabled by default?)
  • When sharing, I type the email
    • Frontend makes a request with the email GET users:search?{email}, and if the recipient has the Public Profile enabled (or an allowed list, matching domain), it returns the profile
  • When listing a shared resource, if there is an unknown gid, the frontend makes a request GET users/{gid} and:
    • if the recipient has the Public Profile, it returns the profile: it can be listed nicely
    • if not, it is shown as an anonymous user

Definition of Done

image

Event Horizon

Preview Give feedback
  1. a:webserver
    pcrespov

Tasks

Preview Give feedback
No tasks being tracked yet.
@odeimaiz odeimaiz transferred this issue from ITISFoundation/osparc-simcore Nov 25, 2024
@odeimaiz odeimaiz added the PO issue Created by Product owners label Nov 25, 2024
@calys
Copy link

calys commented Nov 27, 2024

New User Story
Idea of an alternative User Story

  • Public Profile preference ("show my email", disabled by default)
  • When I want to share something, I start typing a user name or an email
  • When I am typing, I see the list of matching users that are visible to me (e.g. because they belong to the same organisation)
  • There is a mention below or above the typing field stating that I can type an email address
  • If I select an existing user, the validation button is "Share"
  • If I type a non-existing (or not-visible-to-me) email address, the button shows "Send Invitation"

Behaviour when "Send Invitation" is pressed:

  • An email is sent at the email addresses that was entered

  • A notification is shown, stating that "an invitation to access project/study {name} has been sent to {email}"

  • The email contains

    • an invitation (i.e. a link) to access the Study/Project {study.Name}
    • a sentence describing what osparc (or sim4life, or TIP, etc...) is about and a line like "If you do not already have an account, request one here"
    • a sentence with "If you believe you received this email by error, please contact {product.support-email}."
  • If the email recipient clicks on the invitation link:

    • he/she has to login (if not done already), on the main login/landing page of the product. Note that the email address used to login CAN be different than the one used in the invitation email.
    • he/she sees the usual notification in the platform "study/project {name} has been shared with you by {sharer.name}"
  • else:

    • the study/project is NOT (yet) shared
    • the "sharing" can be marked as "pending", if that concept already somehow exists (TBD)

@calys
Copy link

calys commented Nov 27, 2024

[EDIT] After discussion with Odei, it seems the "tentative" user story above is too ambitious and costly to implement, sadly.
We can therefore implement the original user story first, as it closes a gap and should be much much simpler.

We can decide how to proceed later...

@pcrespov
Copy link
Member

NOTE: Modify services/web/server/src/simcore_service_webserver/projects/projects_api.py:_get_project_lock_state to comply with privacy settings.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PO issue Created by Product owners
Projects
None yet
Development

No branches or pull requests

4 participants