-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Get and search users applying privacy settings 🗃️ #6966
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6966 +/- ##
===========================================
- Coverage 86.99% 73.21% -13.78%
===========================================
Files 1621 1408 -213
Lines 63937 56137 -7800
Branches 2033 1033 -1000
===========================================
- Hits 55623 41103 -14520
- Misses 7980 14881 +6901
+ Partials 334 153 -181
Continue to review full report in Codecov by Sentry.
|
7eaf541
to
031d39d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you need to regenerate the openapi specs. as the test is failing
.../simcore_postgres_database/migration/versions/58012c1e1b1b_set_privacy_hide_email_to_true.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
services/web/server/src/simcore_service_webserver/users/_users_rest.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/users/_users_rest.py
Outdated
Show resolved
Hide resolved
68f92ae
to
e4aad80
Compare
ae95280
to
c94a135
Compare
Quality Gate failedFailed conditions |
What do these changes do?
username
,email
orfirst/last_name
(if privacy settings allows):POST /users:search
withmatch
andlimit
in request bodyprimary_group_id
:GET /groups/{primary_group_id}/users
by(wont be used)user_id
:GET users/{user_id}
/users
to/admin/users
since it was used for admin purposesRelated issue/s
users
domain for improved layer separation and upgrading to asyncpg #6937How to test
test_get_and_search_public_users
Dev-ops
None