Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [unit] webserver 03 and [unit] settings-library (both mypy and tests) #6773

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Fixes [unit] webserver 03 and [unit] settings-library (both mypy and tests) #6773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79e86e2
tests
pcrespov Nov 20, 2024
9c673b2
fixes imports
pcrespov Nov 20, 2024
e78e7b1
fixes mypy
pcrespov Nov 20, 2024
0678f6c
fixes tests
pcrespov Nov 20, 2024
49c67aa
fixes tsts
pcrespov Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,7 @@ async def test_list_service_usage(
assert mock_export_usage_services.called
args = mock_export_usage_services.call_args[1]

assert args["order_by"] == OrderBy.model_validate(_order_by)
assert (
args["order_by"].model_dump() == OrderBy.model_validate(_order_by).model_dump()
)
assert args["filters"] == ServiceResourceUsagesFilters.model_validate(_filter)
2 changes: 1 addition & 1 deletion services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ async def test_list_service_usage_with_order_by_query_param(
_, error = await assert_status(resp, status.HTTP_422_UNPROCESSABLE_ENTITY)
assert mock_list_usage_services.called
assert error["status"] == status.HTTP_422_UNPROCESSABLE_ENTITY
assert error["errors"][0]["message"].startswith("Invalid JSON")
assert "Invalid JSON" in error["errors"][0]["message"]

# with order by without direction
_filter = {"field": "started_at"}
Expand Down
Loading