Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [unit] webserver 03 and [unit] settings-library (both mypy and tests) #6773

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 20, 2024

What do these changes do?

  • fixes [unit] webserver 03
image - fixes settings library tests and mypy

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov added this to the Event Horizon milestone Nov 20, 2024
@pcrespov pcrespov self-assigned this Nov 20, 2024
@pcrespov pcrespov force-pushed the fix/webserver-tests branch from c5a0824 to 79e86e2 Compare November 20, 2024 10:12
@pcrespov pcrespov marked this pull request as draft November 20, 2024 10:12
@pcrespov pcrespov changed the title fixes webserver tests WIP: fixes webserver tests Nov 20, 2024
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ask one more time once ready to review

@pcrespov pcrespov changed the title WIP: fixes webserver tests Fixes [unit] webserver 03 and [unit] settings-library (both mypy and tests) Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (66a492f) to head (49c67aa).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6773      +/-   ##
===============================================================================
+ Coverage                                        83.86%   87.45%   +3.58%     
===============================================================================
  Files                                             1513     1288     -225     
  Lines                                            60993    53825    -7168     
  Branches                                          2010     1007    -1003     
===============================================================================
- Hits                                             51149    47070    -4079     
+ Misses                                            9525     6599    -2926     
+ Partials                                           319      156     -163     
Flag Coverage Δ
integrationtests 64.78% <ø> (+11.29%) ⬆️
unittests 87.36% <44.11%> (+3.67%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.23% <100.00%> (-0.01%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.99% <100.00%> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.07% <ø> (-0.09%) ⬇️
director_v2 76.56% <ø> (-0.09%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (-0.04%) ⬇️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.64% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.70% <ø> (+9.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a492f...49c67aa. Read the comment docs.

---- 🚨 Try these New Features:

@pcrespov pcrespov marked this pull request as ready for review November 20, 2024 10:35
@pcrespov pcrespov requested a review from GitHK November 20, 2024 10:36
@pcrespov pcrespov merged commit c38b064 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 20, 2024
73 of 76 checks passed
@pcrespov pcrespov deleted the fix/webserver-tests branch November 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants