Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Greenify pylint (after Pydantic v2 migration) #6747

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 18, 2024

What do these changes do?

Fix pylint issues after Pydantic v2 migration.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 18, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.02%. Comparing base (fa57c9e) to head (29c6ca9).
Report is 15 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6747      +/-   ##
===============================================================================
- Coverage                                        84.11%   84.02%   -0.09%     
===============================================================================
  Files                                             1530     1212     -318     
  Lines                                            65522    50505   -15017     
  Branches                                          2226      847    -1379     
===============================================================================
- Hits                                             55114    42439   -12675     
+ Misses                                           10072     7918    -2154     
+ Partials                                           336      148     -188     
Flag Coverage Δ
integrationtests 53.45% <100.00%> (+0.14%) ⬆️
unittests 83.90% <75.00%> (-1.38%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.28% <ø> (-0.05%) ⬇️
pkg_dask_task_models_library 96.57% <100.00%> (-0.04%) ⬇️
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.31% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (+7.14%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director ∅ <ø> (∅)
director_v2 76.35% <ø> (-12.20%) ⬇️
dynamic_scheduler 96.59% <0.00%> (ø)
dynamic_sidecar 89.79% <100.00%> (+1.56%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (-0.26%) ⬇️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 79.33% <ø> (-1.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa57c9e...29c6ca9. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo changed the title ♻️ Fix pylint ♻️ Greenify pylint (after Pydantic v2 migration) Nov 19, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@giancarloromeo giancarloromeo merged commit 3250e5d into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
74 of 90 checks passed
@giancarloromeo giancarloromeo deleted the is4481/fix-pylint branch November 19, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants