Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected keyword argument when constructing errors instances (Director-v2) #6756

Closed
1 task done
giancarloromeo opened this issue Nov 19, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
bug buggy, it does not work as expected
Milestone

Comments

@giancarloromeo
Copy link
Contributor

giancarloromeo commented Nov 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which deploy/s?

No response

Current Behavior

Pylint complains with a bunch of E1123: Unexpected keyword argument errors when invoking the constructor of custom errors:

Linting /home/runner/work/osparc-simcore/osparc-simcore/services/director-v2
Makefile:47: warning: overriding recipe for target '.env'
../../scripts/common.Makefile:81: warning: ignoring old recipe for target '.env'
# Copying makefile from .env-devel
Makefile:47: warning: overriding recipe for target '.env'
../../scripts/common.Makefile:81: warning: ignoring old recipe for target '.env'
Using config file /home/runner/work/osparc-simcore/osparc-simcore/.pylintrc
************* Module simcore_service_director_v2.modules.dask_clients_pool
src/simcore_service_director_v2/modules/dask_clients_pool.py:111:18: E1123: Unexpected keyword argument 'cluster' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/dask_clients_pool.py:111:18: E1123: Unexpected keyword argument 'error' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.modules.dask_client
src/simcore_service_director_v2/modules/dask_client.py:525:18: E1123: Unexpected keyword argument 'job_id' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.modules.clusters_keeper
src/simcore_service_director_v2/modules/clusters_keeper.py:37:18: E1123: Unexpected keyword argument 'eta' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/clusters_keeper.py:41:18: E1123: Unexpected keyword argument 'eta' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.modules.db.repositories.clusters
src/simcore_service_director_v2/modules/db/repositories/clusters.py:162:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:174:18: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:186:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:199:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:204:26: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:228:34: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:238:26: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:248:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:266:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:273:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/modules/db/repositories/clusters.py:285:22: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.modules.db.repositories.comp_runs
src/simcore_service_director_v2/modules/db/repositories/comp_runs.py:120:18: E1123: Unexpected keyword argument 'cluster_id' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.utils.dask
src/simcore_service_director_v2/utils/dask.py:481:14: E1123: Unexpected keyword argument 'original_scheduler_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask.py:481:14: E1123: Unexpected keyword argument 'current_scheduler_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask.py:488:14: E1123: Unexpected keyword argument 'original_scheduler_id' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask.py:488:14: E1123: Unexpected keyword argument 'current_scheduler_id' in constructor call (unexpected-keyword-arg)
************* Module simcore_service_director_v2.utils.dask_client_utils
src/simcore_service_director_v2/utils/dask_client_utils.py:[161](https://github.com/ITISFoundation/osparc-simcore/actions/runs/11908248587/job/33183374969#step:8:162):14: E1123: Unexpected keyword argument 'endpoint' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask_client_utils.py:161:14: E1123: Unexpected keyword argument 'error' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask_client_utils.py:[164](https://github.com/ITISFoundation/osparc-simcore/actions/runs/11908248587/job/33183374969#step:8:165):14: E1123: Unexpected keyword argument 'endpoint' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask_client_utils.py:164:14: E1123: Unexpected keyword argument 'error' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask_client_utils.py:167:14: E1123: Unexpected keyword argument 'endpoint' in constructor call (unexpected-keyword-arg)
src/simcore_service_director_v2/utils/dask_client_utils.py:[167](https://github.com/ITISFoundation/osparc-simcore/actions/runs/11908248587/job/33183374969#step:8:168):14: E1123: Unexpected keyword argument 'error' in constructor call (unexpected-keyword-arg)
************* Module test_modules_comp_scheduler_dask_scheduler
tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py:1097:8: E1123: Unexpected keyword argument 'original_scheduler_id' in constructor call (unexpected-keyword-arg)
tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py:1097:8: E1123: Unexpected keyword argument 'current_scheduler_id' in constructor call (unexpected-keyword-arg)
tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py:1184:28: E1123: Unexpected keyword argument 'job_id' in constructor call (unexpected-keyword-arg)
tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py:1220:28: E1123: Unexpected keyword argument 'job_id' in constructor call (unexpected-keyword-arg)
tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py:1521:8: E1123: Unexpected keyword argument 'eta' in constructor call (unexpected-keyword-arg)

The issues seems in the errors hierarchy and conflicts with __init__ method.

Expected Behavior

No errors.

Steps To Reproduce

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

No branches or pull requests

5 participants