Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Pydantic V2: Unify errors dv 2 #6763

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 19, 2024

What do these changes do?

This PR converts DirectorError class to inherit from OsparcErrorMixin and RuntimeError.
This leads to quite a few changes.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 19, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 19, 2024
@sanderegg sanderegg self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 59.13978% with 38 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (dcdc863) to head (7a549de).

❗ There is a different number of reports uploaded between BASE (dcdc863) and HEAD (7a549de). Click for more details.

HEAD has 39 uploads less than BASE
Flag BASE (dcdc863) HEAD (7a549de)
unittests 54 15
Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6763      +/-   ##
===============================================================================
- Coverage                                        84.85%   77.24%   -7.61%     
===============================================================================
  Files                                             1382     1005     -377     
  Lines                                            56116    44734   -11382     
  Branches                                          1296      436     -860     
===============================================================================
- Hits                                             47616    34555   -13061     
- Misses                                            8308    10087    +1779     
+ Partials                                           192       92     -100     
Flag Coverage Δ *Carryforward flag
integrationtests 64.79% <58.69%> (+0.08%) ⬆️ Carriedforward from 180c5f0
unittests 73.16% <100.00%> (-11.27%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter ∅ <ø> (∅)
director 76.07% <ø> (ø)
director_v2 76.59% <58.69%> (+0.34%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.75% <ø> (+0.25%) ⬆️
payments 92.77% <ø> (ø)
resource_usage_tracker ∅ <ø> (∅)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 66.85% <ø> (-13.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc863...7a549de. Read the comment docs.

---- 🚨 Try these New Features:

@sanderegg sanderegg marked this pull request as ready for review November 19, 2024 12:13
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Strange that no tests for dynamic-sidecar broke. Please have a look if the integration tests still work as expected

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Let's talk offline about get_error and left some suggestions about how to raise and handle custom exceptions.

@sanderegg sanderegg merged commit c50d79c into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
@sanderegg sanderegg deleted the unify-error-dv-2 branch November 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants