-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Pydantic V2: Unify errors dv 2 #6763
♻️Pydantic V2: Unify errors dv 2 #6763
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6763 +/- ##
===============================================================================
- Coverage 84.85% 77.24% -7.61%
===============================================================================
Files 1382 1005 -377
Lines 56116 44734 -11382
Branches 1296 436 -860
===============================================================================
- Hits 47616 34555 -13061
- Misses 8308 10087 +1779
+ Partials 192 92 -100
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Strange that no tests for dynamic-sidecar broke. Please have a look if the integration tests still work as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. Let's talk offline about get_error
and left some suggestions about how to raise and handle custom exceptions.
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_base_scheduler.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/api/routes/computations.py
Outdated
Show resolved
Hide resolved
...ces/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_factory.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_pipelines.py
Show resolved
Hide resolved
4cee5d0
to
85875e8
Compare
c50d79c
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
Quality Gate passedIssues Measures |
What do these changes do?
This PR converts
DirectorError
class to inherit fromOsparcErrorMixin
andRuntimeError
.This leads to quite a few changes.
Related issue/s
How to test
Dev-ops checklist