Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adding missing db insert field #6742

Merged
merged 2 commits into from
Nov 18, 2024
Merged

🐛 adding missing db insert field #6742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815e336
adding missing db insert field
matusdrobuliak66 Nov 18, 2024
7e015a9
Merge branch 'master' into bugfix/insert-tags-uuid-bug
matusdrobuliak66 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions services/web/server/src/simcore_service_webserver/projects/_db_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import sqlalchemy as sa
from aiopg.sa.connection import SAConnection
from aiopg.sa.result import RowProxy
from models_library.projects import ProjectAtDB
from models_library.projects import ProjectAtDB, ProjectID
from models_library.projects_nodes import Node
from models_library.projects_nodes_io import NodeIDStr
from models_library.users import UserID
Expand Down Expand Up @@ -164,14 +164,18 @@ async def _get_tags_by_project(conn: SAConnection, project_id: str) -> list:

@staticmethod
async def _upsert_tags_in_project(
conn: SAConnection, project_index_id: int, project_tags: list[int]
conn: SAConnection,
project_index_id: int,
project_uuid: ProjectID,
project_tags: list[int],
) -> None:
for tag_id in project_tags:
await conn.execute(
pg_insert(projects_tags)
.values(
project_id=project_index_id,
tag_id=tag_id,
project_uuid_for_rut=project_uuid,
)
.on_conflict_do_nothing()
)
Expand Down
1 change: 1 addition & 0 deletions services/web/server/src/simcore_service_webserver/projects/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def _reraise_if_not_unique_uuid_error(err: UniqueViolation):
await self._upsert_tags_in_project(
conn=conn,
project_index_id=project_index,
project_uuid=project_uuid,
project_tags=project_tag_ids,
)
selected_values["tags"] = project_tag_ids
Expand Down
Loading