Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adding missing db insert field #6742

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 18, 2024

What do these changes do?

  • 🐛 adding missing db insert field

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 18, 2024 10:40
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (c83d60c) to head (7e015a9).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c83d60c) and HEAD (7e015a9). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (c83d60c) HEAD (7e015a9)
unittests 31 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6742      +/-   ##
==========================================
- Coverage   87.41%   82.20%   -5.21%     
==========================================
  Files        1570      613     -957     
  Lines       63322    31096   -32226     
  Branches     2119      265    -1854     
==========================================
- Hits        55351    25562   -29789     
+ Misses       7644     5473    -2171     
+ Partials      327       61     -266     
Flag Coverage Δ
integrationtests 64.85% <100.00%> (+11.43%) ⬆️
unittests 87.20% <100.00%> (+1.48%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.58% <ø> (-14.33%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.82% <ø> (-29.96%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.71% <100.00%> (+1.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83d60c...7e015a9. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 18, 2024 11:30
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.
Can you please add a test that covers this issue as well. this way we are covered when it is modified.

@matusdrobuliak66 matusdrobuliak66 merged commit a381aa6 into ITISFoundation:master Nov 18, 2024
85 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants