Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Fix: Avoid null parameters in requests #6601

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 25, 2024

What do these changes do?

Found in the organizations list. Fix: make them empty objects

Bug:
Bug

Fixed:
Fixed

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 25, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 25, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 25, 2024
Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) October 25, 2024 10:36
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually you could have unit tests for that kind of things? since there is an API, maybe you could have something that checks that all the calls are fitting?

@odeimaiz
Copy link
Member Author

actually you could have unit tests for that kind of things? since there is an API, maybe you could have something that checks that all the calls are fitting?

I don't think that unit tests are the solution to this, mainly because usually they require a larger context and even proper resources /data/configuration in the backend.

Maybe I should resume and increase the e2e-frontend testing...

@odeimaiz odeimaiz merged commit 3a71fde into ITISFoundation:master Oct 25, 2024
51 checks passed
@odeimaiz odeimaiz deleted the fix/avoid-null-params branch October 25, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants