-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [e2e-frontend] Navigation Bar and User Menu #6603
🎨 [e2e-frontend] Navigation Bar and User Menu #6603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6603 +/- ##
===========================================
- Coverage 87.87% 60.68% -27.19%
===========================================
Files 1552 606 -946
Lines 62416 30738 -31678
Branches 2085 265 -1820
===========================================
- Hits 54847 18653 -36194
- Misses 7251 12024 +4773
+ Partials 318 61 -257
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 nice!
…imcore into e2e-frontend/user-menu
…imcore into e2e-frontend/user-menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Quality Gate passedIssues Measures |
What do these changes do?
Extend the Navigation Bar testing and some User Menu testing.
It also adds a test that would detect the bug as mentioned by @sanderegg in this comment.
Related issue/s
How to test
Dev-ops checklist