♻️ Clean up simcore webserver environment ⚠️ DEVOPS

[YuryHrytsuk]

What do these changes do?

Make env variables of Webserver clean, transparent and easy to understand. The env_file has been removed from docker-compoes webesrver service. The environment of docker-compose webserver service has been updated.

Related issue/s

• closes Ensure Simcore Webserver is given only necessary env variables osparc-ops-environments#268
• related to Refactor osparc stack env-var handling #3635
• goes together with Clean up simcore webserver env osparc-ops-environments#273

How to test

Deploy the whole stack and check whether simcore webserver is up and running without any errors in logs

DevOps Checklist

⚠️ DEVOPS: Make sure the config of deployment agent is updated according to the changes in this PR

Make sure to provide the following environment variables:

• SWARM_STACK_NAME
• AIODEBUG_SLOW_DURATION_SECS
• DIAGNOSTICS_SLOW_DURATION_SECS
• STORAGE_PORT
• RESOURCE_USAGE_TRACKER_HOST
• WEBSERVER_DEV_FEATURES_ENABLED
• WEBSERVER_LOGLEVEL
• LOG_FORMAT_LOCAL_DEV_ENABLED
• WEBSERVER_HOST
• WEBSERVER_FRONTEND
• WEBSERVER_ACTIVITY
• WEBSERVER_PROMETHEUS_API_VERSION
• WEBSERVER_PROMETHEUS_URL
• WEBSERVER_CATALOG
• CATALOG_HOST
• CATALOG_PORT
• POSTGRES_DB
• POSTGRES_ENDPOINT
• POSTGRES_HOST
• POSTGRES_PASSWORD
• POSTGRES_PORT
• POSTGRES_USER
• WEBSERVER_DIAGNOSTICS
• DIAGNOSTICS_MAX_AVG_LATENCY
• DIAGNOSTICS_MAX_TASK_DELAY
• DIRECTOR_V2_HOST
• DIRECTOR_V2_PORT
• DIRECTOR_HOST
• DIRECTOR_PORT
• WEBSERVER_EMAIL
• SMTP_HOST
• SMTP_PORT
• WEBSERVER_EXPORTER
• WEBSERVER_GARBAGE_COLLECTOR
• INVITATIONS_HOST
• INVITATIONS_LOGLEVEL
• INVITATIONS_OSPARC_URL
• INVITATIONS_PASSWORD
• INVITATIONS_PORT
• INVITATIONS_SECRET_KEY
• INVITATIONS_USERNAME
• WEBSERVER_LOGIN
• LOGIN_REGISTRATION_CONFIRMATION_REQUIRED
• LOGIN_REGISTRATION_INVITATION_REQUIRED
• LOGIN_2FA_REQUIRED
• REDIS_HOST
• REDIS_PORT
• RESOURCE_MANAGER_RESOURCE_TTL_S
• WEBSERVER_SCICRUNCH
• SCICRUNCH_API_BASE_URL
• SCICRUNCH_API_KEY
• WEBSERVER_SESSION_SECRET_KEY
• WEBSERVER_STATICWEB
• STORAGE_ENDPOINT
• STORAGE_HOST
• STORAGE_PORT
• WEBSERVER_STUDIES_DISPATCHER
• STUDIES_ACCESS_ANONYMOUS_ALLOWED
• STUDIES_DEFAULT_SERVICE_THUMBNAIL
• WEBSERVER_TRACING
• TRACING_ENABLED
• TRACING_ZIPKIN_ENDPOINT
• TRACING_THRIFT_COMPACT_ENDPOINT
• WEBSERVER_PROJECTS
• PROJECTS_MAX_COPY_SIZE_BYTES
• PROJECTS_MAX_NUM_RUNNING_DYNAMIC_NODES
• RABBIT_HOST
• RABBIT_PASSWORD
• RABBIT_PORT
• RABBIT_USER
• WEBSERVER_GUNICORN_CMD_ARGS
• WEBSERVER_DB_LISTENER
• WEBSERVER_ANNOUNCEMENTS
• WEBSERVER_NOTIFICATIONS
• WEBSERVER_CLUSTERS
• WEBSERVER_GROUPS
• WEBSERVER_META_MODELING
• WEBSERVER_PRODUCTS
• WEBSERVER_PUBLICATIONS
• WEBSERVER_SOCKETIO
• WEBSERVER_TAGS
• WEBSERVER_USERS
• WEBSERVER_VERSION_CONTROL
• WB_GC_GARBAGE_COLLECTOR
• WB_GC_LOGLEVEL
• WB_GC_RESOURCE_MANAGER_RESOURCE_TTL_S
• WB_GC_ANNOUNCEMENTS
• WB_GC_ACTIVITY
• WB_GC_CATALOG
• WB_GC_NOTIFICATIONS
• WB_GC_DB_LISTENER
• WB_GC_DIAGNOSTICS
• WB_GC_EMAIL
• WB_GC_EXPORTER
• WB_GC_FRONTEND
• WB_GC_LOGIN
• WB_GC_PROJECTS
• WB_GC_SCICRUNCH
• WB_GC_STATICWEB
• WB_GC_TRACING
• WB_GC_CLUSTERS
• WB_GC_GROUPS
• WB_GC_META_MODELING
• WB_GC_PRODUCTS
• WB_GC_PUBLICATIONS
• WB_GC_SOCKETIO
• WB_GC_STUDIES_DISPATCHER
• WB_GC_TAGS
• WB_GC_USERS
• WB_GC_VERSION_CONTROL
• WB_DB_EL_LOGLEVEL
• WB_DB_EL_DB_LISTENER
• WB_DB_EL_SOCKETIO
• WB_DB_EL_ANNOUNCEMENTS
• WB_DB_EL_ACTIVITY
• WB_DB_EL_CATALOG
• WB_DB_EL_NOTIFICATIONS
• WB_DB_EL_DIAGNOSTICS
• WB_DB_EL_EMAIL
• WB_DB_EL_EXPORTER
• WB_DB_EL_FRONTEND
• WB_DB_EL_GARBAGE_COLLECTOR
• WB_DB_EL_LOGIN
• WB_DB_EL_PROJECTS
• WB_DB_EL_SCICRUNCH
• WB_DB_EL_STATICWEB
• WB_DB_EL_STORAGE
• WB_DB_EL_STUDIES_DISPATCHER
• WB_DB_EL_TRACING
• WB_DB_EL_CLUSTERS
• WB_DB_EL_GROUPS
• WB_DB_EL_META_MODELING
• WB_DB_EL_PRODUCTS
• WB_DB_EL_PUBLICATIONS
• WB_DB_EL_TAGS
• WB_DB_EL_USERS
• WB_DB_EL_VERSION_CONTROL

[codecov]

Codecov Report

Merging #4491 (d89e2b3) into master (f2f6a81) will increase coverage by 1.7%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #4491     +/-   ##
========================================
+ Coverage    84.7%   86.5%   +1.7%     
========================================
  Files        1007    1007             
  Lines       43186   43186             
  Branches     1001    1001             
========================================
+ Hits        36618   37371    +753     
+ Misses       6349    5586    -763     
- Partials      219     229     +10     

Flag	Coverage Δ
integrationtests	66.8% <100.0%> (+26.1%)	⬆️
unittests	84.2% <100.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...re_service_webserver/garbage_collector/settings.py	100.0% <ø> (+23.5%)	⬆️
...er/src/simcore_service_webserver/login/settings.py	98.5% <ø> (ø)
...ore_service_webserver/resource_manager/settings.py	100.0% <ø> (ø)
...e_service_webserver/studies_dispatcher/settings.py	100.0% <ø> (ø)
.../simcore_service_webserver/application_settings.py	98.2% <100.0%> (ø)
...re_service_webserver/application_settings_utils.py	97.8% <100.0%> (ø)

... and 66 files with indirect coverage changes

[matusdrobuliak66]

Thanks!

[sanderegg]

next steps should be made for this sooner rather than later.

[sanderegg]

thanks for taking care of this.

[GitHK]

Nice, thanks for taking care of this.

[mrnicegyu11]

lgtm

[codeclimate]

Code Climate has analyzed commit d89e2b3 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication