-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix webserver twilio env (:warning: DEVOPS) #4566
🐛 Fix webserver twilio env (:warning: DEVOPS) #4566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4566 +/- ##
========================================
+ Coverage 85.3% 86.4% +1.1%
========================================
Files 1007 1007
Lines 43187 43187
Branches 1012 1012
========================================
+ Hits 36852 37351 +499
+ Misses 6103 5604 -499
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks a lot
Kudos, SonarCloud Quality Gate passed! |
Code Climate has analyzed commit 3139297 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. As discussed I am not sure whether this can have consequences on local builds. I guess the e2e tests would complain if there is one.
What do these changes do?
🐛 Add missing TWILIO ENV to a
webserver
. These ENV variables are necessary for some products for login functionality. Otherwise, webserver fails to start because the validation does not passRelated issue/s
How to test
webserver
launches succesfullyDevOps Checklist