Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix webserver twilio env (:warning: DEVOPS) #4566

Merged

Conversation

YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Aug 2, 2023

What do these changes do?

🐛 Add missing TWILIO ENV to a webserver. These ENV variables are necessary for some products for login functionality. Otherwise, webserver fails to start because the validation does not pass

Related issue/s

How to test

  • Run whole ops stack locally and ensure that webserver launches succesfully

DevOps Checklist

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4566 (3139297) into master (2e33ecd) will increase coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4566     +/-   ##
========================================
+ Coverage    85.3%   86.4%   +1.1%     
========================================
  Files        1007    1007             
  Lines       43187   43187             
  Branches     1012    1012             
========================================
+ Hits        36852   37351    +499     
+ Misses       6103    5604    -499     
  Partials      232     232             
Flag Coverage Δ
integrationtests 66.6% <ø> (-1.6%) ⬇️
unittests 84.1% <ø> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk self-assigned this Aug 2, 2023
@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) August 2, 2023 09:41
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks a lot

@YuryHrytsuk YuryHrytsuk requested a review from pcrespov as a code owner August 2, 2023 11:27
@YuryHrytsuk YuryHrytsuk requested review from sanderegg and GitHK August 2, 2023 11:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit 3139297 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. As discussed I am not sure whether this can have consequences on local builds. I guess the e2e tests would complain if there is one.

@YuryHrytsuk YuryHrytsuk merged commit 4faea96 into ITISFoundation:master Aug 2, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
@YuryHrytsuk YuryHrytsuk changed the title 🐛 Fix webserver twilio env 🐛 Fix webserver twilio env (:warning: DEVOPS) Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants