Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flaky inputs changes detection in dy-static-file-server services #157

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 15, 2024

What do these changes do?

Fix buggy inputs detection. Previous version would give up after a bit causing the CI to be flaky.

Related issue number

Checklist

  • I think the code is well written
  • I updated the table of contents (make toc)
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@GitHK GitHK self-assigned this Nov 15, 2024
@GitHK GitHK added t:bug Something isn't working t:enhancement New feature or request labels Nov 15, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 15, 2024
@GitHK GitHK marked this pull request as ready for review November 15, 2024 06:28
@GitHK GitHK changed the title Avoids flaky detections Fixes flaky inputs changes detection in dy-static-file-server services Nov 15, 2024
@GitHK GitHK requested a review from bisgaard-itis November 15, 2024 06:45
Copy link

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Just a few questions from my side

@GitHK GitHK merged commit 8389369 into master Nov 15, 2024
2 checks passed
@GitHK GitHK deleted the avoids-flaky-detections branch November 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Something isn't working t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants