Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pydantic2 migration made integration tests green #6719

Merged
merged 54 commits into from
Nov 18, 2024
Merged

pydantic2 migration made integration tests green #6719

merged 54 commits into from
Nov 18, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 14, 2024 •
edited
Loading

What do these changes do?

Bonus:

  • fixed issues with missing common-library across multiple tests and services
  • disabled openentelemtry when putting up simcore stack for tests

Related issue/s

How to test

Dev-ops checklist

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (44f85bf) to head (c369d3e).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files 
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6719      +/-   ##
===============================================================================
+ Coverage                                        81.13%   87.37%   +6.24%     
===============================================================================
  Files                                             1530     1522       -8     
  Lines                                            63824    60311    -3513     
  Branches                                          2226     2148      -78     
===============================================================================
+ Hits                                             51781    52695     +914     
+ Misses                                           11708     7288    -4420     
+ Partials                                           335      328       -7
Flag Coverage Δ
integrationtests 64.71% <100.00%> (+11.39%) ⬆️
unittests 85.24% <89.74%> (+0.14%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.32% <ø> (ø)
pkg_dask_task_models_library 96.61% <100.00%> (ø)
pkg_models_library 91.18% <100.00%> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.31% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.33% <80.00%> (-0.06%) ⬇️
pkg_settings_library 91.12% <ø> (ø)
pkg_simcore_sdk 85.37% <100.00%> (+7.10%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <100.00%> (ø)
autoscaling ∅ <ø> (∅)
catalog 90.57% <100.00%> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (+0.39%) ⬆️
datcore_adapter 93.17% <ø> (ø)
director 58.38% <ø> (-0.05%) ⬇️
director_v2 90.82% <100.00%> (+14.62%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (+30.00%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (-0.26%) ⬇️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (+0.14%) ⬆️
storage 89.66% <100.00%> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <100.00%> (+8.61%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f85bf...c369d3e. Read the comment docs.

@GitHK GitHK changed the title Pr osparc pydantic2 integration libraries2 Fix integration tests simcore-sdk and dynamic-sidecar Nov 14, 2024
@GitHK GitHK self-assigned this Nov 14, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 14, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 14, 2024
@GitHK GitHK marked this pull request as ready for review November 14, 2024 10:34
@GitHK GitHK requested a review from giancarloromeo November 14, 2024 10:34
Andrei Neagu added 2 commits November 14, 2024 13:24
refactor
7b3c820
Merge remote-tracking branch 'upstream/pydantic_v2_migration_do_not_s…
ff307d6 
…quash_updates' into pr-osparc-pydantic2-integration-libraries2
@GitHK GitHK changed the title Fix integration tests simcore-sdk and dynamic-sidecar Fixed most of the integration tests Nov 14, 2024
sanderegg
sanderegg reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few things

packages/pytest-simcore/src/pytest_simcore/docker_compose.py Outdated Show resolved Hide resolved
packages/pytest-simcore/src/pytest_simcore/simcore_storage_service.py Outdated Show resolved Hide resolved
services/dask-sidecar/requirements/prod.txt Show resolved Hide resolved
services/dynamic-sidecar/requirements/prod.txt Show resolved Hide resolved
services/dynamic-sidecar/tests/integration/test_modules_long_running_tasks.py Outdated Show resolved Hide resolved
services/storage/requirements/prod.txt Show resolved Hide resolved
services/storage/src/simcore_service_storage/models.py Show resolved Hide resolved
services/web/server/src/simcore_service_webserver/exporter/_formatter/xlsx/code_description.py Show resolved Hide resolved
Andrei Neagu and others added 2 commits November 14, 2024 13:41
@GitHK GitHK changed the title Fixed most of the integration tests pydantic2 migration made integration tests green Nov 15, 2024
@GitHK GitHK requested review from sanderegg and pcrespov November 15, 2024 12:22
sanderegg
sanderegg reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments, there are a few left and I think you forgot all the dev.txt and ci.txt files

packages/models-library/src/models_library/api_schemas_catalog/services.py Outdated Show resolved Hide resolved
packages/pytest-simcore/src/pytest_simcore/docker_registry.py Show resolved Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/storage.py Show resolved Hide resolved
services/agent/requirements/prod.txt Show resolved Hide resolved
services/web/server/tests/integration/01/test_garbage_collection.py Outdated Show resolved Hide resolved
@GitHK GitHK requested a review from sanderegg November 15, 2024 12:53
Andrei Neagu added 3 commits November 18, 2024 08:52
Merge remote-tracking branch 'upstream/pydantic_v2_migration_do_not_s…
a7a3257 
…quash_updates' into pr-osparc-pydantic2-integration-libraries2
reverting
8e6175d
renaming
6bdc21a
sanderegg
sanderegg approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Andrei Neagu added 2 commits November 18, 2024 13:15
updated description
819cee6
Merge remote-tracking branch 'upstream/pydantic_v2_migration_do_not_s…
c369d3e 
…quash_updates' into pr-osparc-pydantic2-integration-libraries2
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit fa57c9e into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 18, 2024
83 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-pydantic2-integration-libraries2 branch November 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

Assignees

@GitHK GitHK

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
5 participants
@GitHK @giancarloromeo @pcrespov @sanderegg @matusdrobuliak66