Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates installation scripts and improves documentation #418

Conversation

prasadtalasila
Copy link
Contributor

  • Fixes mistakes in the vagrant installation scripts and documentation.
    Removes hardcoded host network interface from the Vagrantfile; Users
    can now select any one of their available network interfaces.
  • Adds script for installing gitlab.
  • Makes all the yarn commands cross-platform. Now the developers can work on all OS platforms.
  • Updates client env.js to check for browser environment
  • Updates mkdocs version and its dependencies
  • Fixes some mistakes in the documentation
  • Updates npm publish steps regarding publishing packages to the default npm registry

Resolves issues #298, #302 and #417.

This PR includes all the changes suggested in PR #364

Vagrant virtual machines
- Seperater Packages: [client website](client/CLIENT.md) and
[lib microservice](servers/lib/LIB-MS.md)
## How to install?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing punctuation in header

@@ -18,6 +18,31 @@
Please see the [features](user/features.md) page
to get a sense of the things you can do in DaaS.

??? Question "What is the scope and current capabilities of DTaaS?"

1. DTaaS is a web based interface to allow you to invoke various tools
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code block style

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Merging #418 (ed26e86) into feature/distributed-demo (0d52819) will increase coverage by 1.72%.
Report is 4 commits behind head on feature/distributed-demo.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/distributed-demo     #418      +/-   ##
============================================================
+ Coverage                     64.63%   66.36%   +1.72%     
============================================================
  Files                            43       35       -8     
  Lines                           574      440     -134     
  Branches                         35       29       -6     
============================================================
- Hits                            371      292      -79     
+ Misses                          180      130      -50     
+ Partials                         23       18       -5     

see 8 files with indirect coverage changes

Components Coverage Δ
Website 63.47% <ø> (ø)
Lib Microservice ∅ <ø> (∅)

@prasadtalasila
Copy link
Contributor Author

@nichlaes , the yarn test:e2e of client/ is still not cross-platform. Do you have any suggestions on making it cross-platform?


In this examples the DT will run for 10 seconds, with a stepsize of 100ms.
Thereafter it is possible to examine the logs produce in
```/workspace/examples/digital_twins/drobotti_rmqfmu/target```.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenced code blocks should be surrounded by blank lines

Copy link

codeclimate bot commented Jan 8, 2024

Code Climate has analyzed commit e674b42 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 6

View more on Code Climate.

@prasadtalasila prasadtalasila merged commit abc90a6 into INTO-CPS-Association:feature/distributed-demo Jan 10, 2024
5 of 6 checks passed
@prasadtalasila prasadtalasila deleted the cross-platform-yarn-commands branch January 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants