Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use published packages in install scripts #302

Closed
prasadtalasila opened this issue Nov 24, 2023 · 5 comments
Closed

Use published packages in install scripts #302

prasadtalasila opened this issue Nov 24, 2023 · 5 comments
Assignees
@nichlaes
Labels
enhancement New feature or request

Comments

@prasadtalasila
Copy link
Contributor

The library and runner packages has been published in packages. These package must be included in install scripts. The existing yarn install commands need to be removed.
@prasadtalasila prasadtalasila added the enhancement New feature or request label Nov 24, 2023
@prasadtalasila prasadtalasila added this to the Release v0.4.0 milestone Nov 24, 2023
@prasadtalasila
Copy link
Contributor Author

The same can be done for react website using dtaas-client.zip file. Using the zip file avoids the installation of playwright and other devDependencies. These dependencies take a lot of resources during installation.

@prasadtalasila
Copy link
Contributor Author

The immediate update for the install scripts is to change

cd "${TOP_DIR}/client" || exit
yarn install
yarn build

to

cd "${TOP_DIR}/client" || exit
yarn install --production
yarn build

@prasadtalasila
Copy link
Contributor Author

The client.yml need to be updated to publish dtaas-client.zip as an artifact of github action.

@prasadtalasila
Copy link
Contributor Author

The client.yml need to be updated to publish dtaas-client.zip as an artifact of github action.

A decision has been made to build docker containers for each of components including client. This work is being pursued in issue #381.

@prasadtalasila prasadtalasila removed this from the Release v0.4.0 milestone Dec 22, 2023
@prasadtalasila prasadtalasila mentioned this issue Jan 4, 2024
Merged
@prasadtalasila
Copy link
Contributor Author

PR #418 resolves the pending work in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nichlaes nichlaes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prasadtalasila @nichlaes