Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds localhost install feature (rebased version of PR #348) #380

Merged
merged 23 commits into from
Dec 21, 2023

Conversation

prasadtalasila
Copy link
Contributor

No description provided.

@prasadtalasila
Copy link
Contributor Author

prasadtalasila commented Dec 18, 2023

@nichlaes , one of the problems is that the default username is user1. This leads to problems for localhost and trial installation. The users are likely to use https://gitlab.com as authentication provider with user-level OAuth application. These users will have their own gitlab account. We need to make username as another argument to the single-script-install.sh. The changes are required in:

  1. fileConfig.local.yml
  2. fileConfig.trial.yml
  3. docker run..... ml-workspace-user1 to change base URL
  4. single-script.install.sh

Can you please look into this? Thanks.

@prasadtalasila
Copy link
Contributor Author

@nichlaes

printf "Remember to change foo.com and Gitlab OAuth details to your \
local settings in the following files.\n "
printf "1. %s/client/build/env.js\n " "$TOP_DIR"
printf "2. %s/servers/config/gateway/dynamic/fileConfig.yml\n " "$TOP_DIR"

The fileConfig.yml line is required only for trial config. This can be skipped for local config. Can you please put an if condition here to run the printf only in the trial config? Thanks.

deploy/single-script-install.sh Show resolved Hide resolved
@@ -167,24 +194,16 @@ docker run -d \
--restart always \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp -R "${TOP_DIR}/files/user1" "${TOP_DIR}/files/${username}"
docker run -d \
 -p 8090:8080 \
  --name "ml-workspace-${username}" \
  -v "${TOP_DIR}/files/user1:/workspace" \
  -v "${TOP_DIR}/files/common:/workspace/common" \
  --env AUTHENTICATE_VIA_JUPYTER="" \
  --env WORKSPACE_BASE_URL="${username}" \
  --shm-size 512m \
  --restart always \
  mltooling/ml-workspace-minimal:0.13.2 || true


```bash
wget https://raw.githubusercontent.com/INTO-CPS-Association/DTaaS/feature/distributed-demo/deploy/single-script-install.sh
bash single-script-install.sh --env local
Copy link
Contributor Author

@prasadtalasila prasadtalasila Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash single-script-install.sh --env local --user username


```bash
wget https://raw.githubusercontent.com/INTO-CPS-Association/DTaaS/feature/distributed-demo/deploy/single-script-install.sh
bash single-script-install.sh
bash single-script-install.sh --env trial
Copy link
Contributor Author

@prasadtalasila prasadtalasila Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash single-script-install.sh --env trial --user username

Copy link

codeclimate bot commented Dec 21, 2023

Code Climate has analyzed commit 4162cb5 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila prasadtalasila merged commit e9c3cf0 into feature/distributed-demo Dec 21, 2023
4 checks passed
@prasadtalasila prasadtalasila deleted the localhost-install branch December 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants