Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301 run dtaas with localhost domain name #348

Conversation

nichlaes
Copy link
Collaborator

@nichlaes nichlaes commented Dec 6, 2023

fixes issue #301 and adds local script

@nichlaes nichlaes linked an issue Dec 6, 2023 that may be closed by this pull request
deploy/config/client/env.local.js Show resolved Hide resolved
deploy/single-script-install.sh Outdated Show resolved Hide resolved
deploy/local.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the codeclimate comments and add documentation. Thanks.

deploy/config/client/env.local.js Show resolved Hide resolved
deploy/config/gateway/fileConfig.local.yml Show resolved Hide resolved
deploy/config/gateway/fileConfig.local.yml Outdated Show resolved Hide resolved
deploy/config/gateway/fileConfig.local.yml Outdated Show resolved Hide resolved
deploy/local.sh Outdated Show resolved Hide resolved
deploy/single-script-install.sh Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Merging #348 (968cde5) into feature/distributed-demo (3080647) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/distributed-demo     #348   +/-   ##
=========================================================
  Coverage                     64.63%   64.63%           
=========================================================
  Files                            43       43           
  Lines                           574      574           
  Branches                         35       35           
=========================================================
  Hits                            371      371           
  Misses                          180      180           
  Partials                         23       23           
Components Coverage Δ
Website 63.47% <ø> (ø)
Lib Microservice 58.95% <ø> (ø)

@nichlaes
Copy link
Collaborator Author

@prasadtalasila everything should be resolved now


The DTaaS react website requires Gitlab OAuth provider.
If you need more help with this step, please see
the [Authentication page](client/auth.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sufficient to have user-owned oauth application for localhost and trial installations. Pæease mention this point in information box both here and on trial installation page.

Please also create a section at the 3nd of auth.md mentioning about the use of user-owned oauth application.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasadtalasila I don't understand the second part about the auth.md for the use of user-owned oauth

Also what the 3nd section of auth.md is

docs/admin/trial.md Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/admin/localhost.md Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/trial.md Show resolved Hide resolved
docs/admin/trial.md Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/trial.md Outdated Show resolved Hide resolved
docs/admin/trial.md Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/localhost.md Outdated Show resolved Hide resolved
docs/admin/trial.md Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Dec 15, 2023

Code Climate has analyzed commit 56f7b09 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila
Copy link
Contributor

Continued in PR #380

prasadtalasila added a commit that referenced this pull request Dec 21, 2023
  - Updates installation scripts and config files
     to make the localhost install possible.
  - Makes both trial and localhost install create
     single user only.

---------
Co-authored-by: nichlaes <[email protected]>
@prasadtalasila prasadtalasila deleted the 301-run-dtaas-with-localhost-domain-name branch December 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run DTaaS with localhost domain name
3 participants