-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
301 run dtaas with localhost domain name #348
301 run dtaas with localhost domain name #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the codeclimate comments and add documentation. Thanks.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #348 +/- ##
=========================================================
Coverage 64.63% 64.63%
=========================================================
Files 43 43
Lines 574 574
Branches 35 35
=========================================================
Hits 371 371
Misses 180 180
Partials 23 23
|
@prasadtalasila everything should be resolved now |
|
||
The DTaaS react website requires Gitlab OAuth provider. | ||
If you need more help with this step, please see | ||
the [Authentication page](client/auth.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is sufficient to have user-owned oauth application for localhost and trial installations. Pæease mention this point in information box both here and on trial installation page.
Please also create a section at the 3nd of auth.md mentioning about the use of user-owned oauth application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadtalasila I don't understand the second part about the auth.md for the use of user-owned oauth
Also what the 3nd section of auth.md is
Code Climate has analyzed commit 56f7b09 and detected 0 issues on this pull request. View more on Code Climate. |
Continued in PR #380 |
- Updates installation scripts and config files to make the localhost install possible. - Makes both trial and localhost install create single user only. --------- Co-authored-by: nichlaes <[email protected]>
fixes issue #301 and adds local script