Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#283 Missing images in a sequence #317

Merged
merged 35 commits into from
Feb 16, 2024
Merged

#283 Missing images in a sequence #317

merged 35 commits into from
Feb 16, 2024

Conversation

kirschbombe
Copy link
Contributor

@kirschbombe kirschbombe commented May 2, 2022

@kirschbombe kirschbombe self-assigned this May 2, 2022
Copyediting, updating for new viewers, adding highlighting, etc.
@glenrobson
Copy link
Member

Cookbook Editors are happy for this to go ahead but would suggest the following changes:

  • ID is capitalised in implementation notes but should be lowercase as its a property

Suggest rewritting:
"ID, type, height, width, and items properties. The first two are required by the API for any Canvas, the dimensions tell the viewer to maintain a viewing space of the appropriate size, and the final property ensures the widely used IIIF validator will pass the Manifest."

To something like:

"id, type, height, width, and items properties. The items property is empty in this example. The spec doesn’t require the items property but the IIIF-C validator will fail to validate a canvas without an items property as it differentiates between canvas references found in ranges and canvas found in sequences by the presence of items.

Feel free to re-word the above but it was felt it was slightly clearer on the soft requirment for items in a canvas.

@glenrobson glenrobson marked this pull request as ready for review September 20, 2023 15:10
@glenrobson
Copy link
Member

OK to make changes requested by TRC:

IIIF/trc#120

Then we can merge.

@glenrobson glenrobson added the meta: ready-to-merge Pull request is ready to merge into main branch label Feb 9, 2024
@glenrobson glenrobson merged commit 96c87fa into master Feb 16, 2024
1 check passed
@glenrobson glenrobson deleted the 0283-missing-image branch February 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content: image meta: approved-by-trc Recipe has been approved by the TRC meta: ready-to-merge Pull request is ready to merge into main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dealing with Missing images
3 participants