Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with Missing images #283

Closed
glenrobson opened this issue Dec 17, 2021 · 10 comments · Fixed by #317
Closed

Dealing with Missing images #283

glenrobson opened this issue Dec 17, 2021 · 10 comments · Fixed by #317

Comments

@glenrobson
Copy link
Member

glenrobson commented Dec 17, 2021

Recipe Name

Missing images in sequence.

Use case

I have a manuscript which has an image missing. I want to included a canvas with some content to show the user that there should/could be an image there and also make sure the recto/verso paged functionality isn't thrown due to this missing image.

See this example: IIIF/api#33

@regisrob
Copy link
Member

Live examples in Mirador 2 (manuscripts with missing pages represented as empty canvases):
https://demos.biblissima.fr/florus/florus-dispersus/mirador/
https://demos.biblissima.fr/bbmn-1713/mirador/

@kirschbombe
Copy link
Contributor

Thanks for the example links, @regisrob! I used the Biblissima examples last year to model how we approach this here at UCLA :)

@kirschbombe kirschbombe added the meta: ready-for-recipe Discussion has concluded, recipe to be written label Apr 15, 2022
@kirschbombe kirschbombe removed the meta: ready-for-recipe Discussion has concluded, recipe to be written label May 2, 2022
@kirschbombe kirschbombe linked a pull request May 2, 2022 that will close this issue
@glenrobson
Copy link
Member Author

We also tried this at the NLW: https://glenrobson.github.io/iiif/2021/06/04/NLW-Journals.html

@glenrobson
Copy link
Member Author

Just looking at @regisrob example it looks like they also have empty canvases (from https://demos.biblissima.fr/iiif/metadata/florus-dispersus/manifest.json):

{

    "@id": ["http://demos.biblissima-condorcet.fr/iiif/metadata/florus-dispersus/canvas/canvas-1"](http://demos.biblissima-condorcet.fr/iiif/metadata/florus-dispersus/canvas/canvas-1),
    "@type": "sc:Canvas",
    "label": "Lacune (32r)",
    "width": 860,
    "height": 1200

},

@regisrob how do you get the custom thumbnail to appear? Is that a local customisation of Mirador?

Also this example:

{

    "@id": ["https://iiif.biblissima.fr/bbmn-1713-t1/canvas/c-1"](https://iiif.biblissima.fr/bbmn-1713-t1/canvas/c-1),
    "@type": "sc:Canvas",
    "label": "p.1",
    "width": 3464,
    "height": 4898,
    "metadata": [
        {
            "label": "Cote",
            "value": "Page non retrouvée"
        },
        {
            "label": "Titre",
            "value": "Catalogus quorumdam Manuscriptorum Bibliothecae Vaticanae"
        },
        {
            "label": "Notice",
            "value": ["https://www.unicaen.fr/puc/sources/thecae/maur/BBMN_Roma_Bibl.Vaticana_1738_01"](https://www.unicaen.fr/puc/sources/thecae/maur/BBMN_Roma_Bibl.Vaticana_1738_01)
        }
    ]

},

from https://iiif.biblissima.fr/bbmn-1713-t1/manifest.json

@glenrobson
Copy link
Member Author

Related discussion on api issue: IIIF/api#1017

@glenrobson
Copy link
Member Author

Also this discussion in mirador: ProjectMirador/mirador#1231

@kirschbombe
Copy link
Contributor

@glenrobson - if you load those manifests in UV or the Mirador demo, they lose the placeholder thumbnails. It would be great if the community could agree on a way that viewers could handle empty canvases that could be implemented in each of the viewers. Short of that, it seems like local customizations (like Biblissima) or using a placeholder image on a Canvas where the image is missing are the current solutions.

@kirschbombe
Copy link
Contributor

Also this discussion in mirador: ProjectMirador/mirador#1231

It looks like Mirador 2 addressed empty canvases, but it doesn't look like that made it into M3?

@glenrobson
Copy link
Member Author

It looks like it was never merged in mirador 2 but it looks very similar to @regisrob implementation.

@regisrob
Copy link
Member

regisrob commented May 8, 2022

@glenrobson Yes it was a local customization in Mirador 2, but I cannot remember why it was never merged in the codebase, nor why the placeholder text and thumbnail for empty canvases has not been implemented in Mirador 3...
I am not completely sure but I remember this first demo was entirely custom (kind of a hack) to make M2 support empty canvases. The second one may be based on Johannes's work mentioned above, but I am not completely sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants