Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): turn off the "emoticons_alt_exists" and "asciiart_alt_exists" rules #1658

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Sep 8, 2023

Rule bug: emoticons_alt_exists, asciiart_alt_exists

This PR is related to the following issue(s):

#805

Additional information can be found here:

Testing reference:

  1. run the test/v2/checker/accessibility/rules/asciiart_alt_exists_ruleunit/AsciiArt-detectInvalid.html, the NR: "Verify that ASCII art has a text alternative" shouldn't show up.
  2. run test/v2/checker/accessibility/rules/emoticons_alt_exists_ruleunit/Text-hasEmoticons.html, the NR: "Verify that ASCII art has a text alternative" shouldn't show up.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet September 8, 2023 14:58
@shunguoy shunguoy marked this pull request as ready for review September 8, 2023 14:58
@ErickRenteria ErickRenteria merged commit 2e7bb2d into master Sep 19, 2023
15 checks passed
@shunguoy shunguoy deleted the dev-805 branch September 29, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants