Merge pull request #1658 from IBMa/dev-805

fix(engine): turn off the "emoticons_alt_exists" and "asciiart_alt_exists" rules
IBMa · Sep 19, 2023 · 2e7bb2d · 2e7bb2d
2 parents a55b157 + e16230b
commit 2e7bb2d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 584 deletions.
diff --git a/accessibility-checker-engine/src/v4/rules/asciiart_alt_exists.ts b/accessibility-checker-engine/src/v4/rules/asciiart_alt_exists.ts
@@ -37,12 +37,16 @@ export let asciiart_alt_exists: Rule = {
             "group": "ASCII art must have a text alternative"
         }
     },
+    /**
+     * Decision in planning 9/7/23 that this rule causes more reviews that we see actual problems in content, so turn these rules off
     rulesets: [{
         "id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0"],
         "num": ["1.1.1"],
         "level": eRulePolicy.VIOLATION,
         "toolkitLevel": eToolkitLevel.LEVEL_ONE
     }],
+    */
+    rulesets: [],
     act: [],
     run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
         const ruleContext = context["dom"].node as Element;

diff --git a/accessibility-checker-engine/src/v4/rules/emoticons_alt_exists.ts b/accessibility-checker-engine/src/v4/rules/emoticons_alt_exists.ts
@@ -37,12 +37,17 @@ export let emoticons_alt_exists: Rule = {
             "group": "Emoticons must have a short text alternative that describes their purpose"
         }
     },
+    /**
+     * Decision in planning 9/7/23 that this rule causes more reviews that we see actual problems in content, so turn these rules off
+    
     rulesets: [{
         "id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0"],
         "num": ["1.1.1"],
         "level": eRulePolicy.VIOLATION,
         "toolkitLevel": eToolkitLevel.LEVEL_TWO
     }],
+    */
+    rulesets: [],
     act: [],
     run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
         const validateParams = {