Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 23.1.0 #194645

Merged
merged 4 commits into from
Oct 27, 2024
Merged

node 23.1.0 #194645

merged 4 commits into from
Oct 27, 2024

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Oct 16, 2024 •
edited by chenrui333
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Oct 16, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 16, 2024
@branchvincent
Copy link
Member

From #193982, I think we also want to ship this with corepack enabled

@bcomnes
Copy link
Contributor

bcomnes commented Oct 18, 2024

Anything I can do to help get this landed?

@Bo98
Copy link
Member

Bo98 commented Oct 19, 2024 •
edited
Loading

Anything I can do to help get this landed?

There's a significant regression in path handling that's getting fixed in nodejs/node#55414. We can probably cherry-pick that once its merged.

@bcomnes
Copy link
Contributor

bcomnes commented Oct 19, 2024

Ouch sounds bad. Thanks for the context.

@AnthonyPoschen
Copy link

any chance to get a bump to 22.10.0 in the meantime?
came across an issue that was patched with the latest patch fix.
nodejs/node#54573 (comment)

@SMillerDev
Copy link
Member

any chance to get a bump to 22.10.0 in the meantime? came across an issue that was patched with the latest patch fix. nodejs/node#54573 (comment)

Go ahead: https://docs.brew.sh/Updating-Software-in-Homebrew

@harpchad
Copy link
Contributor

any chance to get a bump to 22.10.0 in the meantime? came across an issue that was patched with the latest patch fix. nodejs/node#54573 (comment)

Go ahead: https://docs.brew.sh/Updating-Software-in-Homebrew

#195089

@ovflowd
Copy link

ovflowd commented Oct 21, 2024

Anything I can do to help get this landed?

There's a significant regression in path handling that's getting fixed in nodejs/node#55414. We can probably cherry-pick that once its merged.

We got this merged, but it is pending release. Thanks for keeping an eye on it.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 23, 2024
@Bo98 Bo98 added in progress Stale bot should stay away and removed stale No recent activity labels Oct 23, 2024
@chenrui333 chenrui333 mentioned this pull request Oct 24, 2024
Closed
1 task
@chenrui333 chenrui333 force-pushed the bump-node-23.0.0 branch 2 times, most recently from efc4133 to 9804bc5 Compare October 24, 2024 22:38
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 25, 2024
@chenrui333 chenrui333 changed the title node 23.0.0 node 23.1.0 Oct 25, 2024
BrewTestBot and others added 2 commits October 26, 2024 11:27
@BrewTestBot @chenrui333
node 23.1.0
d87ebfd 
node: npm 10.9.0

Signed-off-by: Rui Chen <[email protected]>

node: remove `--without-corepack`

Signed-off-by: Rui Chen <[email protected]>

node: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
emscripten: update test
62ac81b 
Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Oct 26, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Oct 26, 2024
@chenrui333
Copy link
Member

will handle the corepack conflict as followup

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 26, 2024
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 27, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 27, 2024
Merged via the queue into master with commit 69cabf0 Oct 27, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-node-23.0.0 branch October 27, 2024 21:45
This was referenced Oct 27, 2024
Merged
Merged
Merged
Merged
@stefanb stefanb mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@BrewTestBot @branchvincent @bcomnes @Bo98 @AnthonyPoschen @SMillerDev @harpchad @ovflowd @chenrui333 @MikeMcQuaid