Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corepack: merged into node #195770

Merged
merged 5 commits into from
Oct 28, 2024
Merged

corepack: merged into node #195770

merged 5 commits into from
Oct 28, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Oct 27, 2024 •
edited
Loading

corepack: deprecate in favor of corepack from node formula

followup #194645

relates to

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Oct 27, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Oct 27, 2024
@chenrui333 chenrui333 marked this pull request as draft October 27, 2024 22:23
@chenrui333
Copy link
Member Author

need a rebase after:

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 27, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed formula deprecated Formula deprecated labels Oct 27, 2024
@chenrui333 chenrui333 changed the title corepack: deprecate in favor of corepack from node formula corepack: merged into node Oct 27, 2024
@chenrui333 chenrui333 marked this pull request as ready for review October 28, 2024 13:54
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 28, 2024
@chenrui333 chenrui333 requested a review from a team October 28, 2024 14:04
@daeho-ro daeho-ro added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit fb6324d Oct 28, 2024
18 checks passed
@daeho-ro daeho-ro deleted the corepack-deprecate branch October 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @daeho-ro