Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Blade Stop (Root) trigger #3254

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

guilherme-gm
Copy link
Member

@guilherme-gm guilherme-gm commented Nov 15, 2023

Pull Request Prelude

Changes Proposed

Extract the conditions to start SC_BLADESTOP to its own function, since it has several conditions, and with the rebalance (#3253), more RE/Pre-RE differences.

And also fixes some mistakes in the logic, making it closer to official behavior. This affects both Pre-RE and RE.

Changes:

  1. The target's equipped weapon no longer affects the range of Blade Stop. This applies for both Pre-RE and RE. In current code, a bare-handed monk would only blade-stop targets 1-cell away
  2. Player attackers are only blade stopped from far away (> 2 cells) in Pre-RE -- My tests in renewal showed that a Hunter will only get blade-stopped if they are up to 2 cells away from the Monk.

Discussion here: #3253 (comment) . Copying skyleo findings:

So yeah, if attacker player and attacking bladestopped player -> no extra range check(still needs to be in attack range of course). if attacking mob -> no bladestop check

If attacker mob or anything else non-player and attacking bladestopped anything -> range check of 2 

In Aegis 11.2 the code is written in a way that it assumes that mobs cannot use Bladestop, so when someone is in Bladestop there is code that assumes that someone is a player, without checking if it's player type.

Huge thanks to skyleo for helping with Pre-RE validation.

This change is NOT related to the rebalance of classes made in RE.

Issues addressed: None, I think

Copy link
Contributor

@skyleo skyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nitpick: Commits should ideally start with a capitalized imperative verb.

it now has each of its conditions documented separatelly.

this will also make easier to read and to include rebalance-related checks.
1. Only in Pre-RE player attacks will cause blade stop to trigger from
   far away.
   In RE, distance checks apply the same as for non-player attacks (i.e. monsters)
2. For both modes, Blade Stop distance is always to 2 cells, regardless
   of equipped weapon. Even bare hands should work for up to 2 cells.
@MishimaHaruna MishimaHaruna merged commit 95d8d08 into HerculesWS:master Nov 22, 2023
215 of 255 checks passed
@guilherme-gm guilherme-gm deleted the fix-bladestop branch March 2, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants