Fix socket connections #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
fix_urllib3_chunked_error
branch
2 times, most recently
from
1491078 to
1d66438
Compare
mattjala
force-pushed
the
fix_urllib3_chunked_error
branch
from
1d66438 to
9c9ced9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #371, socket operations started failing. This seems to be due to an incompatibility between
requests>=2.29.0andurllib3>=2.0.0. The only change that PR made to dependencies was to bumpaiobotocore, which doesn't requireurllib3>=2.0.0, so I'm not sure why the package versions downloaded changed as a result.To resolve this
urllib3<=2.0.0to avoid the incompatibility with newer requestsrequests <=2.31.0to fix the incompatibility withrequests-unixsocket. `The requests version was already fixed at this value in Use old requests version #363, but it looks like a dependabot PR was merged after that.This PR also includes a new workflow to test the socket specifically to prevent this from happening in the future.