Add windows socket test

HDFGroup · Jun 12, 2024 · 1d66438 · 1d66438
1 parent 7a58943
commit 1d66438
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -16,8 +16,8 @@ jobs:
     steps:
       - name: 'Checkout Repository'
         uses: actions/checkout@v3
+
       - name: 'Dependency Review'
-        uses: actions/dependency-review-action@v1
+        uses: actions/dependency-review-action@v4
         with:
-          # verify=False is never used in HSDS
-          allow-ghsas: ["GHSA-9wx4-h78v-vm56"]
+          allow-ghsas: GHSA-9wx4-h78v-vm56
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -186,13 +186,14 @@ jobs:
       HDF5_VOL_CONNECTOR: REST
       ROOT_DIR: ${{github.workspace}}/hsdsdata
       BUCKET_NAME: hsdstest
-    
+
     name: Test HSDS with socket
-    runs-on: ubuntu-latest
     strategy:
       matrix:
+        os: [ubuntu-latest, windows-latest]
         python-version: ["3.12"]
 
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}
@@ -213,9 +214,9 @@ jobs:
           pip install -e .
 
       # Requests 2.32.0 breaks requests-unixsocket, used by HSDS for socket connections
-      - name: Fix requests version
-        run: |
-          pip install requests==2.31.0
+      # - name: Fix requests version
+      #  run: |
+      #    pip install requests==2.31.0
 
       - name: Run HSDS unit tests
         shell: bash