Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed true/false definition and added missing h5_interm_group example #5092

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

brtnfld
Copy link
Contributor

@brtnfld brtnfld commented Nov 12, 2024

No description provided.

@brtnfld brtnfld added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Branch - 2.0 PRs to the HDF5 2.x maintenance branch labels Nov 12, 2024
@brtnfld brtnfld added this to the 2.0.0 milestone Nov 12, 2024
@@ -64,13 +64,13 @@ main(void)
/* Next commented call causes error stack to be printed out; the next one
* works fine; is it a bug or a feature? EIP 04-25-07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address the comment!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior is documented, so we should remove the comment:

If name includes either a relative path or an absolute path to the target link, intermediate steps along the path must be verified before the existence of the target link can be safely checked. If the path is not verified, and an intermediate element of the path does not exist, the API will fail.

That said, as this behavior seems to demand attention, as evidenced by workarounds (https://gist.github.com/jzrake/3025642), we should look into handling this use case.

@derobins derobins merged commit 915a7ab into HDFGroup:develop Nov 13, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch - 2.0 PRs to the HDF5 2.x maintenance branch Component - C Library Core C library issues (usually in the src directory) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants