-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the VOL for HDF5 2.0.0 changes. #73
Conversation
… newer than 1.14 HDF5 versions
It should pass as soon as HDFGroup/hdf5#5092 gets merged. |
This is ready to be reviewed. It still gets the infinite library close error, but that is not the objective of this PR. |
|
||
//! [H5Oget_info3_snip] | ||
|
||
+#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing this was just carried over from the previous patch, but is there an issue here in the connector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also passes for me when the code is activated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, however, find the string attribute
status = H5Gget_info(g2_id, &g2_info); | ||
printf("Group /G1/G2 has %d member(s)\n", (int)g2_info.nlinks); | ||
- | ||
+#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to pass for me if I activate the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the logs,
HDF5-DIAG: Error detected in HDF5 (2.0.0) MPI-process 0:
#000: ../../src/H5L.c line 1514 in H5Lget_name_by_idx(): unable to get link name
major: Links
minor: Can't get value
#1: ../../src/H5VLcallback.c line 5179 in H5VL_link_get(): link get failed
major: Virtual Object Layer
minor: Can't get value
#2: ../../src/H5VLcallback.c line 5147 in H5VL__link_get(): link get failed
major: Virtual Object Layer
minor: Can't get value
It passes because error checking is not done in the examples.
Removed the use of H5VLpeek_connector_id_by_name as it was removed in newer than 1.14 HDF5 versions.
Updated for HDF5 2.0 VOL API changes, updated tests to pull from newest HDF5 source.